Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
| return obj.data | ||
| .replaceAll("\r\n", "\r") | ||
| .replaceAll("\r", "\r\n") | ||
| .replaceAll(/(: \r\n|:\r\n|\r\n:|\r\n :)/gm, ":") |
There was a problem hiding this comment.
This caused
URL;VALUE=URI:\r\nEND:VEVENT
to turn into
URL;VALUE=URI:END:VEVENT
This doesn't seem like much but it basically destroys the END of VEVENT by pulling it up instead of in a new line which is essential for the ICAL parser to know that that's the end of the VEVENT. 🤯
So,
URL;VALUE=URI:END:VEVENT
is what it becomes whereas it should have been
URL;VALUE=URI:
END:VEVENT
📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖 Two Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
Current Playwright Test Results Summary✅ 52 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 03/24/2023 05:06:07pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 263089a Started: 03/24/2023 05:01:13pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests user can add multiple organizer address
Retry 1 • Initial Attempt |
5.63% (12)12 / 213 runsfailed over last 7 days |
33.80% (72)72 / 213 runsflaked over last 7 days |
zomars
left a comment
There was a problem hiding this comment.
You found a needle in the haystack @alishaz-polymath great work! 🙏🏽
Agreed that we should follow up with unit testing.
What does this PR do?
Removes bad Broad Spectrum ReplaceAll call from the ICal body sanitizer function that resulted in poor EOL replacement in very specific situations on a shared Apple Calendar (and I imagine a few other calendars).
The Sanitizer function requires a nice proper testing and potentially revamp, but this should do as a hotfix for now without any major issues.
Fixes: #7201
Environment: Staging(main branch)
Type of change