Skip to content

fix: add calendar button layout shift#7930

Merged
PeerRich merged 9 commits intomainfrom
7853-cal-1299-installed-apps-add-new-calendar-weird-behaviour-after-clicking-button
Apr 2, 2023
Merged

fix: add calendar button layout shift#7930
PeerRich merged 9 commits intomainfrom
7853-cal-1299-installed-apps-add-new-calendar-weird-behaviour-after-clicking-button

Conversation

@G3root
Copy link
Copy Markdown
Contributor

@G3root G3root commented Mar 24, 2023

What does this PR do?

Fixes #7853

after:

Screenshot 2023-03-24 18:02:19

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@G3root G3root requested a review from a team March 24, 2023 12:34
@linear
Copy link
Copy Markdown

linear bot commented Mar 24, 2023

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal ❌ Failed (Inspect) Apr 2, 2023 10:19am
inkblot ❌ Failed (Inspect) Apr 2, 2023 10:19am
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2023 10:19am

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 24, 2023

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 233.33 KB (🟡 +1 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Sixty-five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/404 8.45 KB 241.77 KB 69.08% (+/- <0.01%)
/[user] 70.21 KB 303.53 KB 86.72% (+/- <0.01%)
/[user]/[type] 91.95 KB 325.27 KB 92.93% (🟡 +0.01%)
/[user]/[type]/embed 91.97 KB 325.3 KB 92.94% (+/- <0.01%)
/[user]/embed 70.27 KB 303.6 KB 86.74% (+/- <0.01%)
/apps 167.19 KB 400.51 KB 114.43% (+/- <0.01%)
/apps/[slug] 190.91 KB 424.23 KB 121.21% (+/- <0.01%)
/apps/[slug]/[...pages] 392.31 KB 625.64 KB 178.75% (+/- <0.01%)
/apps/categories 152.08 KB 385.41 KB 110.12% (+/- <0.01%)
/apps/categories/[category] 155.95 KB 389.28 KB 111.22% (+/- <0.01%)
/apps/installed/[category] 196.94 KB 430.26 KB 122.93% (🟢 -0.05%)
/auth/error 19.24 KB 252.57 KB 72.16% (+/- <0.01%)
/auth/forgot-password 25.63 KB 258.96 KB 73.99% (+/- <0.01%)
/auth/forgot-password/[id] 32.83 KB 266.16 KB 76.05% (+/- <0.01%)
/auth/login 40.1 KB 273.43 KB 78.12% (+/- <0.01%)
/auth/logout 7.56 KB 240.89 KB 68.83% (+/- <0.01%)
/availability 155.39 KB 388.72 KB 111.06% (+/- <0.01%)
/availability/[schedule] 272.15 KB 505.48 KB 144.42% (+/- <0.01%)
/availability/troubleshoot 152.77 KB 386.1 KB 110.31% (🟡 +0.01%)
/booking/[uid] 123.63 KB 356.96 KB 101.99% (+/- <0.01%)
/bookings/[status] 272.47 KB 505.8 KB 144.51% (+/- <0.01%)
/d/[link]/[slug] 91.59 KB 324.92 KB 92.83% (+/- <0.01%)
/d/[link]/[slug]/embed 91.62 KB 324.95 KB 92.84% (+/- <0.01%)
/event-types 349.27 KB 582.6 KB 166.46% (+/- <0.01%)
/event-types/[type] 383.09 KB 616.42 KB 176.12% (+/- <0.01%)
/getting-started/[[...step]] 303.22 KB 536.55 KB 153.30% (+/- <0.01%)
/insights 387.24 KB 620.57 KB 177.30% (🟡 +0.01%)
/more 151.71 KB 385.04 KB 110.01% (+/- <0.01%)
/settings/admin 157.17 KB 390.49 KB 111.57% (+/- <0.01%)
/settings/admin/apps 165.85 KB 399.18 KB 114.05% (+/- <0.01%)
/settings/admin/apps/[category] 165.83 KB 399.16 KB 114.05% (+/- <0.01%)
/settings/admin/flags 160.06 KB 393.38 KB 112.40% (+/- <0.01%)
/settings/admin/impersonation 157.45 KB 390.77 KB 111.65% (+/- <0.01%)
/settings/billing 157.28 KB 390.6 KB 111.60% (+/- <0.01%)
/settings/developer/api-keys 186.43 KB 419.76 KB 119.93% (+/- <0.01%)
/settings/developer/webhooks 159.93 KB 393.26 KB 112.36% (+/- <0.01%)
/settings/developer/webhooks/[id] 190.62 KB 423.95 KB 121.13% (+/- <0.01%)
/settings/developer/webhooks/new 190.48 KB 423.81 KB 121.09% (+/- <0.01%)
/settings/my-account/appearance 171.24 KB 404.57 KB 115.59% (+/- <0.01%)
/settings/my-account/calendars 191.46 KB 424.79 KB 121.37% (+/- <0.01%)
/settings/my-account/conferencing 163.09 KB 396.41 KB 113.26% (+/- <0.01%)
/settings/my-account/general 266.43 KB 499.76 KB 142.79% (+/- <0.01%)
/settings/my-account/profile 274.25 KB 507.58 KB 145.02% (+/- <0.01%)
/settings/security/impersonation 159.32 KB 392.64 KB 112.18% (+/- <0.01%)
/settings/security/password 192.61 KB 425.94 KB 121.70% (+/- <0.01%)
/settings/security/sso 167.01 KB 400.34 KB 114.38% (+/- <0.01%)
/settings/security/two-factor-auth 161.77 KB 395.1 KB 112.88% (🟡 +0.01%)
/settings/teams 156.91 KB 390.24 KB 111.50% (+/- <0.01%)
/settings/teams/[id]/appearance 171.26 KB 404.59 KB 115.60% (+/- <0.01%)
/settings/teams/[id]/billing 157.14 KB 390.47 KB 111.56% (+/- <0.01%)
/settings/teams/[id]/members 297.17 KB 530.5 KB 151.57% (+/- <0.01%)
/settings/teams/[id]/profile 269.46 KB 502.79 KB 143.65% (🟡 +0.01%)
/settings/teams/[id]/sso 167.1 KB 400.43 KB 114.41% (+/- <0.01%)
/settings/teams/new 92.74 KB 326.06 KB 93.16% (+/- <0.01%)
/signup 25.5 KB 258.82 KB 73.95% (+/- <0.01%)
/team/[slug] 72.62 KB 305.94 KB 87.41% (+/- <0.01%)
/team/[slug]/[type] 91.6 KB 324.92 KB 92.84% (+/- <0.01%)
/team/[slug]/[type]/embed 91.63 KB 324.95 KB 92.84% (+/- <0.01%)
/team/[slug]/embed 72.68 KB 306.01 KB 87.43% (+/- <0.01%)
/teams 151.93 KB 385.25 KB 110.07% (+/- <0.01%)
/video/meeting-ended/[uid] 14.67 KB 247.99 KB 70.86% (+/- <0.01%)
/video/meeting-not-started/[uid] 14.3 KB 247.63 KB 70.75% (+/- <0.01%)
/video/no-meeting-found 6.6 KB 239.93 KB 68.55% (+/- <0.01%)
/workflows 164.82 KB 398.15 KB 113.76% (+/- <0.01%)
/workflows/[workflow] 294.04 KB 527.36 KB 150.68% (+/- <0.01%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@PeerRich PeerRich enabled auto-merge (squash) March 24, 2023 15:16
Copy link
Copy Markdown
Member

@CarinaWolli CarinaWolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should left align everything so that the calendar logo and the plus icon are in-line.

@G3root
Copy link
Copy Markdown
Contributor Author

G3root commented Mar 25, 2023

We should left align everything so that the calendar logo and the plus icon are in-line.

@CarinaWolli pushed some changes

Screenshot 2023-03-25 05:53:29

@deploysentinel
Copy link
Copy Markdown

deploysentinel bot commented Mar 25, 2023

No failed tests 🎉

@CarinaWolli
Copy link
Copy Markdown
Member

Still not quite in line, icons and the beginning of the text should be in line like that:

Screenshot 2023-03-27 at 08 03 02

Copy link
Copy Markdown
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In agreement with @CarinaWolli that the alignment needs to be as in the design before this can be merged 🙏

@G3root G3root requested review from a team, CarinaWolli and emrysal March 29, 2023 19:38
@G3root
Copy link
Copy Markdown
Contributor Author

G3root commented Mar 29, 2023

@CarinaWolli new changes
Screenshot 2023-03-30 01:07:36

Copy link
Copy Markdown
Member

@CarinaWolli CarinaWolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now 👍

@PeerRich PeerRich merged commit 81b2e37 into main Apr 2, 2023
@PeerRich PeerRich deleted the 7853-cal-1299-installed-apps-add-new-calendar-weird-behaviour-after-clicking-button branch April 2, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CAL-1299] /installed-apps - Add new calendar: weird behaviour after clicking button

5 participants