Fix/correctly handle Pending Status and fix conditional require confirmation#7911
Fix/correctly handle Pending Status and fix conditional require confirmation#7911
Conversation
…mation as the earlier handles requiresConfirmation threshold as well
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖
|
| Page | Size (compressed) |
|---|---|
global |
210.9 KB (🟡 +3 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
One Page Changed Size
The following page changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load | % of Budget (350 KB) |
|---|---|---|---|
/booking/[uid] |
131.42 KB |
342.33 KB | 97.81% (🟢 -0.01%) |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.
Current Playwright Test Results Summary✅ 66 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 03/23/2023 06:45:53pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 626669a Started: 03/23/2023 06:38:17pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Routing Forms Seeded Routing Form Routing Link - Reporting and CSV Download
Retry 1 • Initial Attempt |
2.66% (5)5 / 188 runsfailed over last 7 days |
27.66% (52)52 / 188 runsflaked over last 7 days |
| const userReschedulingIsOwner = userId && originalRescheduledBooking?.user?.id === userId; | ||
| const isConfirmedByDefault = | ||
| (!eventType.requiresConfirmation && !paymentAppData.price) || userReschedulingIsOwner; | ||
| const isConfirmedByDefault = (!requiresConfirmation && !paymentAppData.price) || userReschedulingIsOwner; |
There was a problem hiding this comment.
requiresConfirmation variable handles requireConfirmation with threshold check.
What does this PR do?
Fixes
Environment: Production
Type of change
How should this be tested?
Checklist