Fix/send responses everywhere customInputs were being sent.#7898
Fix/send responses everywhere customInputs were being sent.#7898hariombalhara merged 12 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! Seven Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
2cdfbc9 to
e82161b
Compare
| @@ -14,7 +14,6 @@ type BookingSelect = { | |||
| }; | |||
| }; | |||
| location: true; | |||
| smsReminderNumber: true; | |||
|
|
||
| const booking = { | ||
| ...bookingRaw, | ||
| responses: bookingResponsesDbSchema.parse(bookingRaw.responses), |
There was a problem hiding this comment.
No need to parse here. getCalEventResponses can handle the parsing itself now.
| } | ||
| } | ||
| return { calEventUserFieldsResponses, calEventResponses }; | ||
| return { userFieldsResponses: calEventUserFieldsResponses, responses: calEventResponses }; |
There was a problem hiding this comment.
This renaming allows us to simply spread over the return value to build cal event.
e82161b to
89a3b07
Compare
89a3b07 to
f62f0bf
Compare
Current Playwright Test Results Summary✅ 66 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 04/03/2023 12:58:54pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: f61d85e Started: 04/03/2023 12:53:31pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests user can add multiple organizer address
Retry 1 • Initial Attempt |
1.70% (3)3 / 176 runsfailed over last 7 days |
31.25% (55)55 / 176 runsflaked over last 7 days |
📄 packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Routing Forms Seeded Routing Form Routing Link - Reporting and CSV Download
Retry 1 • Initial Attempt |
9.21% (14)14 / 152 runsfailed over last 7 days |
24.34% (37)37 / 152 runsflaked over last 7 days |
df85a1f to
57aa5b9
Compare
CarinaWolli
left a comment
There was a problem hiding this comment.
It's also missing for the endpoint to test our zapier trigger. It's this endpoint: https://github.com/calcom/cal.com/blob/main/packages/app-store/zapier/api/subscriptions/listBookings.ts
Could you add that too?
|
inform user when merged: https://app.intercom.com/a/inbox/z9l4o9ru/inbox/admin/5018200/conversation/64?view=List |
|
@CarinaWolli Thanks !! I have added it at that place also now. |
…nto fix/send-responses-everywhere
e7f521d to
5358cdb
Compare
CarinaWolli
left a comment
There was a problem hiding this comment.
LGTM! I pushed a change to add userFieldsResponses to the Zapier payload. Will approve after pr-progress.md is removed
…nto fix/send-responses-everywhere
CarinaWolli
left a comment
There was a problem hiding this comment.
Nice, looking good now 🙌🏻
What does this PR do?
Adds responses everywhere customInputs was being sent earlier
Environment: Production
Type of change
How should this be tested?
Checklist