Conversation
Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖
|
| Page | Size (compressed) |
|---|---|
global |
233.22 KB (🟡 +3 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Seventy Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load | % of Budget (350 KB) |
|---|---|---|---|
/404 |
8.37 KB |
241.58 KB | 69.02% (+/- <0.01%) |
/[user] |
103.33 KB |
336.55 KB | 96.16% (+/- <0.01%) |
/[user]/[type] |
91.79 KB |
325 KB | 92.86% (+/- <0.01%) |
/[user]/[type]/embed |
91.81 KB |
325.03 KB | 92.87% (+/- <0.01%) |
/[user]/book |
183.33 KB |
416.55 KB | 119.02% (🟢 -0.01%) |
/[user]/embed |
103.4 KB |
336.62 KB | 96.18% (+/- <0.01%) |
/apps |
167.06 KB |
400.28 KB | 114.37% (+/- <0.01%) |
/apps/[slug] |
190.78 KB |
424 KB | 121.14% (+/- <0.01%) |
/apps/[slug]/[...pages] |
392.2 KB |
625.42 KB | 178.69% (+/- <0.01%) |
/apps/categories |
151.96 KB |
385.18 KB | 110.05% (+/- <0.01%) |
/apps/categories/[category] |
155.82 KB |
389.04 KB | 111.15% (🟡 +0.01%) |
/apps/installed/[category] |
196.93 KB |
430.15 KB | 122.90% (+/- <0.01%) |
/auth/error |
19.24 KB |
252.46 KB | 72.13% (+/- <0.01%) |
/auth/forgot-password |
25.58 KB |
258.8 KB | 73.94% (+/- <0.01%) |
/auth/forgot-password/[id] |
32.78 KB |
266 KB | 76.00% (+/- <0.01%) |
/auth/login |
40.05 KB |
273.27 KB | 78.08% (+/- <0.01%) |
/auth/logout |
7.56 KB |
240.78 KB | 68.79% (+/- <0.01%) |
/auth/setup |
79.41 KB |
312.63 KB | 89.32% (+/- <0.01%) |
/availability |
155.17 KB |
388.38 KB | 110.97% (+/- <0.01%) |
/availability/[schedule] |
271.97 KB |
505.19 KB | 144.34% (+/- <0.01%) |
/availability/troubleshoot |
152.65 KB |
385.87 KB | 110.25% (+/- <0.01%) |
/booking/[uid] |
123.45 KB |
356.67 KB | 101.91% (+/- <0.01%) |
/bookings/[status] |
272.27 KB |
505.49 KB | 144.43% (+/- <0.01%) |
/d/[link]/[slug] |
91.43 KB |
324.65 KB | 92.76% (+/- <0.01%) |
/d/[link]/[slug]/embed |
91.46 KB |
324.68 KB | 92.77% (+/- <0.01%) |
/d/[link]/book |
182.99 KB |
416.21 KB | 118.92% (+/- <0.01%) |
/event-types |
349.2 KB |
582.42 KB | 166.41% (+/- <0.01%) |
/event-types/[type] |
382.26 KB |
615.48 KB | 175.85% (+/- <0.01%) |
/getting-started/[[...step]] |
303 KB |
536.22 KB | 153.20% (+/- <0.01%) |
/insights |
386.13 KB |
619.35 KB | 176.96% (+/- <0.01%) |
/more |
151.58 KB |
384.8 KB | 109.94% (🟡 +0.01%) |
/settings/admin |
157.04 KB |
390.26 KB | 111.50% (+/- <0.01%) |
/settings/admin/apps |
165.72 KB |
398.94 KB | 113.98% (🟡 +0.01%) |
/settings/admin/apps/[category] |
165.71 KB |
398.93 KB | 113.98% (+/- <0.01%) |
/settings/admin/flags |
159.93 KB |
393.15 KB | 112.33% (+/- <0.01%) |
/settings/admin/impersonation |
157.32 KB |
390.54 KB | 111.58% (+/- <0.01%) |
/settings/billing |
157.15 KB |
390.37 KB | 111.53% (🟡 +0.01%) |
/settings/developer/api-keys |
186.31 KB |
419.53 KB | 119.86% (🟡 +0.01%) |
/settings/developer/webhooks |
159.64 KB |
392.86 KB | 112.25% (+/- <0.01%) |
/settings/developer/webhooks/[id] |
190.49 KB |
423.71 KB | 121.06% (+/- <0.01%) |
/settings/developer/webhooks/new |
190.35 KB |
423.57 KB | 121.02% (+/- <0.01%) |
/settings/my-account/appearance |
171.12 KB |
404.34 KB | 115.52% (🟡 +0.01%) |
/settings/my-account/calendars |
191.34 KB |
424.56 KB | 121.30% (+/- <0.01%) |
/settings/my-account/conferencing |
162.91 KB |
396.13 KB | 113.18% (+/- <0.01%) |
/settings/my-account/general |
266.3 KB |
499.52 KB | 142.72% (+/- <0.01%) |
/settings/my-account/profile |
274.2 KB |
507.42 KB | 144.98% (+/- <0.01%) |
/settings/security/impersonation |
159.19 KB |
392.41 KB | 112.12% (+/- <0.01%) |
/settings/security/password |
192.49 KB |
425.71 KB | 121.63% (+/- <0.01%) |
/settings/security/sso |
166.89 KB |
400.11 KB | 114.32% (+/- <0.01%) |
/settings/security/two-factor-auth |
161.65 KB |
394.86 KB | 112.82% (+/- <0.01%) |
/settings/teams |
156.79 KB |
390 KB | 111.43% (+/- <0.01%) |
/settings/teams/[id]/appearance |
171.14 KB |
404.36 KB | 115.53% (+/- <0.01%) |
/settings/teams/[id]/billing |
157.02 KB |
390.24 KB | 111.50% (+/- <0.01%) |
/settings/teams/[id]/members |
297.02 KB |
530.24 KB | 151.50% (+/- <0.01%) |
/settings/teams/[id]/onboard-members |
49.94 KB |
283.15 KB | 80.90% (+/- <0.01%) |
/settings/teams/[id]/profile |
269.41 KB |
502.63 KB | 143.61% (+/- <0.01%) |
/settings/teams/[id]/sso |
166.98 KB |
400.2 KB | 114.34% (+/- <0.01%) |
/settings/teams/new |
92.68 KB |
325.9 KB | 93.11% (🟡 +0.01%) |
/signup |
25.45 KB |
258.67 KB | 73.91% (🟢 -0.01%) |
/team/[slug] |
105.87 KB |
339.09 KB | 96.88% (+/- <0.01%) |
/team/[slug]/[type] |
91.44 KB |
324.65 KB | 92.76% (+/- <0.01%) |
/team/[slug]/[type]/embed |
91.47 KB |
324.68 KB | 92.77% (+/- <0.01%) |
/team/[slug]/book |
182.99 KB |
416.21 KB | 118.92% (+/- <0.01%) |
/team/[slug]/embed |
105.94 KB |
339.16 KB | 96.90% (+/- <0.01%) |
/teams |
151.8 KB |
385.02 KB | 110.01% (+/- <0.01%) |
/video/meeting-ended/[uid] |
14.67 KB |
247.88 KB | 70.82% (+/- <0.01%) |
/video/meeting-not-started/[uid] |
14.3 KB |
247.52 KB | 70.72% (+/- <0.01%) |
/video/no-meeting-found |
6.6 KB |
239.82 KB | 68.52% (+/- <0.01%) |
/workflows |
164.7 KB |
397.92 KB | 113.69% (+/- <0.01%) |
/workflows/[workflow] |
293.89 KB |
527.11 KB | 150.60% (+/- <0.01%) |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.
Current Playwright Test Results Summary✅ 66 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 03/27/2023 04:35:04pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 88f435f Started: 03/27/2023 04:28:51pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Embed Code Generator Tests Event Type Edit Page open Embed Dialog for the Event Type
Retry 1 • Initial Attempt |
1.89% (4)4 / 212 runsfailed over last 7 days |
19.81% (42)42 / 212 runsflaked over last 7 days |
Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
| if (newTeamFormMethods.formState.touchedFields["slug"] === undefined) { | ||
| newTeamFormMethods.setValue("slug", slugify(e?.target.value)); | ||
| } | ||
| createTeamMutation.reset(); |
There was a problem hiding this comment.
this is to clear server side error when user make change to input. without this the button is disabled even when input has been changed and error is still displayed
emrysal
left a comment
There was a problem hiding this comment.
Merging, asked feedback from @Jaibles though so may need a follow up 🙏 (I believe he would like to feedback his thoughts on the placement etc. of the error message)
This is how we handle errors related to a specific input )which is what your case here is): Not related to this specific instance, but just a note for other errors: where the error is not related to a specific input use an inline banner, don't just have red text. We can't solely rely on colour for error messages for accessibility reasons. It is advisable to also use icons. The padding & background from the banner also helps draw attention to it and visually elevate it from the other UI elements. |
|
@Jaibles okay will change the error message UI here. |
What does this PR do?
Fixes #7771
2) delete button in button group
Screen.Recording.2023-03-23.at.5.56.43.PM.mov
Environment: Staging(main branch) / Production
Type of change