fix: remove "Nameless" from title in booking cancel page#7888
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| )} | ||
| {bookingInfo?.attendees.map((attendee) => ( | ||
| <div key={attendee.name} className="mb-3 last:mb-0"> | ||
| <div key={attendee.name + attendee.email} className="mb-3 last:mb-0"> |
There was a problem hiding this comment.
fixes the same key warning when additional guests are present
📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖 Sixty-six Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
Current Playwright Test Results Summary✅ 52 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 03/23/2023 10:21:54am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 10ceda7 Started: 03/23/2023 10:17:04am UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests user can add multiple organizer address
Retry 1 • Initial Attempt |
7.04% (15)15 / 213 runsfailed over last 7 days |
35.21% (75)75 / 213 runsflaked over last 7 days |
| )} | ||
| <div className="font-medium">{t("what")}</div> | ||
| <div className="col-span-2 mb-6 last:mb-0">{eventName}</div> | ||
| <div className="col-span-2 mb-6 last:mb-0">{props.bookingInfo.title}</div> |
There was a problem hiding this comment.
@G3root can you comment why nameless was coming and how switching from eventName to props.bookingInfo.title fixed it?
Also, is it something that recently regressed or like this always.
There was a problem hiding this comment.
previously event name has been derived from here, in the event of cancelled booking , attendees are empty so it fallbacks to Nameless. using the title of the booking seems reliable here.
i think it is recently regressed.
What does this PR do?
fixes the issue as mentioned in https://threads.com/34457815439?u=34440454662
Type of change