Skip to content

fix: set canonical to https://cal.com on .dev as well#7883

Merged
PeerRich merged 1 commit intomainfrom
fix-canonicals-on-dev
Mar 22, 2023
Merged

fix: set canonical to https://cal.com on .dev as well#7883
PeerRich merged 1 commit intomainfrom
fix-canonicals-on-dev

Conversation

@p6l-richard
Copy link
Copy Markdown
Contributor

@p6l-richard p6l-richard commented Mar 22, 2023

What does this PR do?

updates the canonical logic to set it for cal.dev as well

Fixes # (issue)

  • when on cal.dev, we're currently setting the canonical to cal.dev -- this PR fixes this
    Environment: Staging(main branch) / Production

Type of change

  • Chore (refactoring code, technical debt, workflow improvements)

How should this be tested?

  • After deployment, visit cal.dev/apps and inspect the browser console for the <link rel="canonical"> element. It should display the cal.com/apps link

@p6l-richard p6l-richard requested a review from a team March 22, 2023 14:06
@vercel
Copy link
Copy Markdown

vercel bot commented Mar 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
cal ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 22, 2023 at 2:13PM (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 22, 2023 at 2:13PM (UTC)

@github-actions
Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 210.88 KB (-17 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Sixty-six Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/404 8.37 KB 219.25 KB 62.64% (🟡 +0.01%)
/[user] 111.33 KB 322.21 KB 92.06% (+/- <0.01%)
/[user]/[type] 99.83 KB 310.71 KB 88.77% (🟡 +0.01%)
/[user]/[type]/embed 99.85 KB 310.74 KB 88.78% (+/- <0.01%)
/[user]/book 190.85 KB 401.73 KB 114.78% (🟢 -0.11%)
/[user]/embed 111.39 KB 322.28 KB 92.08% (+/- <0.01%)
/apps 171.04 KB 381.92 KB 109.12% (+/- <0.01%)
/apps/[slug] 194.76 KB 405.64 KB 115.90% (+/- <0.01%)
/apps/[slug]/[...pages] 396.37 KB 607.25 KB 173.50% (+/- <0.01%)
/apps/categories 155.94 KB 366.82 KB 104.81% (+/- <0.01%)
/apps/categories/[category] 159.8 KB 370.68 KB 105.91% (+/- <0.01%)
/apps/installed/[category] 200.96 KB 411.84 KB 117.67% (+/- <0.01%)
/auth/error 19.24 KB 230.13 KB 65.75% (+/- <0.01%)
/auth/forgot-password 25.58 KB 236.47 KB 67.56% (+/- <0.01%)
/auth/forgot-password/[id] 40.9 KB 251.79 KB 71.94% (+/- <0.01%)
/auth/login 40.05 KB 250.94 KB 71.70% (+/- <0.01%)
/auth/logout 7.56 KB 218.44 KB 62.41% (🟡 +0.01%)
/availability 159.15 KB 370.03 KB 105.72% (🟡 +0.01%)
/availability/[schedule] 275.91 KB 486.79 KB 139.08% (🟢 -0.01%)
/availability/troubleshoot 156.62 KB 367.51 KB 105.00% (🟡 +0.01%)
/booking/[uid] 131.42 KB 342.3 KB 97.80% (+/- <0.01%)
/bookings/[status] 268.82 KB 479.71 KB 137.06% (+/- <0.01%)
/d/[link]/[slug] 99.48 KB 310.36 KB 88.67% (🟡 +0.01%)
/d/[link]/[slug]/embed 99.5 KB 310.39 KB 88.68% (+/- <0.01%)
/d/[link]/book 190.51 KB 401.39 KB 114.68% (🟢 -0.11%)
/event-types 353.75 KB 564.64 KB 161.32% (🟡 +0.01%)
/event-types/[type] 386.41 KB 597.29 KB 170.66% (🟢 -0.02%)
/getting-started/[[...step]] 333.55 KB 544.44 KB 155.55% (🟢 -0.18%)
/more 155.56 KB 366.45 KB 104.70% (+/- <0.01%)
/settings/admin 161 KB 371.89 KB 106.25% (🟡 +0.01%)
/settings/admin/apps 193.91 KB 404.79 KB 115.65% (🟡 +0.01%)
/settings/admin/apps/[category] 193.89 KB 404.77 KB 115.65% (+/- <0.01%)
/settings/admin/impersonation 161.29 KB 372.17 KB 106.33% (🟡 +0.01%)
/settings/billing 161.2 KB 372.08 KB 106.31% (+/- <0.01%)
/settings/developer/api-keys 190.27 KB 401.15 KB 114.62% (+/- <0.01%)
/settings/developer/webhooks 163.61 KB 374.49 KB 107.00% (+/- <0.01%)
/settings/developer/webhooks/[id] 194.46 KB 405.34 KB 115.81% (+/- <0.01%)
/settings/developer/webhooks/new 194.32 KB 405.2 KB 115.77% (+/- <0.01%)
/settings/my-account/appearance 175.08 KB 385.96 KB 110.28% (+/- <0.01%)
/settings/my-account/calendars 195.31 KB 406.19 KB 116.05% (🟡 +0.01%)
/settings/my-account/conferencing 166.88 KB 377.76 KB 107.93% (🟡 +0.01%)
/settings/my-account/general 270.18 KB 481.06 KB 137.45% (+/- <0.01%)
/settings/my-account/profile 428.2 KB 639.08 KB 182.60% (🟢 -0.18%)
/settings/security/impersonation 163.16 KB 374.04 KB 106.87% (+/- <0.01%)
/settings/security/password 196.45 KB 407.33 KB 116.38% (+/- <0.01%)
/settings/security/sso 170.85 KB 381.73 KB 109.07% (+/- <0.01%)
/settings/security/two-factor-auth 165.61 KB 376.49 KB 107.57% (+/- <0.01%)
/settings/teams 160.75 KB 371.63 KB 106.18% (+/- <0.01%)
/settings/teams/[id]/appearance 175.1 KB 385.98 KB 110.28% (+/- <0.01%)
/settings/teams/[id]/billing 160.98 KB 371.87 KB 106.25% (+/- <0.01%)
/settings/teams/[id]/members 301.64 KB 512.52 KB 146.44% (+/- <0.01%)
/settings/teams/[id]/profile 273.39 KB 484.27 KB 138.36% (🟡 +0.01%)
/settings/teams/[id]/sso 170.94 KB 381.83 KB 109.09% (🟡 +0.01%)
/signup 25.45 KB 236.33 KB 67.52% (🟡 +0.01%)
/team/[slug] 113.88 KB 324.77 KB 92.79% (+/- <0.01%)
/team/[slug]/[type] 99.48 KB 310.36 KB 88.67% (🟡 +0.01%)
/team/[slug]/[type]/embed 99.51 KB 310.39 KB 88.68% (🟡 +0.01%)
/team/[slug]/book 190.51 KB 401.39 KB 114.68% (🟢 -0.11%)
/team/[slug]/embed 113.95 KB 324.83 KB 92.81% (+/- <0.01%)
/teams 155.78 KB 366.67 KB 104.76% (🟡 +0.01%)
/video/[uid] 84.79 KB 295.67 KB 84.48% (🟢 -0.01%)
/video/meeting-ended/[uid] 22.77 KB 233.66 KB 66.76% (+/- <0.01%)
/video/meeting-not-started/[uid] 22.41 KB 233.29 KB 66.66% (+/- <0.01%)
/video/no-meeting-found 6.6 KB 217.49 KB 62.14% (+/- <0.01%)
/workflows 168.68 KB 379.56 KB 108.45% (+/- <0.01%)
/workflows/[workflow] 298.5 KB 509.38 KB 145.54% (+/- <0.01%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@emrysal
Copy link
Copy Markdown
Contributor

emrysal commented Mar 22, 2023

Looks good to me 👍

@PeerRich PeerRich merged commit 4e24735 into main Mar 22, 2023
@PeerRich PeerRich deleted the fix-canonicals-on-dev branch March 22, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants