Skip to content

chore: removed duplicate destination calendar selector components#7880

Merged
emrysal merged 8 commits intocalcom:mainfrom
Vicolas11:main
Mar 31, 2023
Merged

chore: removed duplicate destination calendar selector components#7880
emrysal merged 8 commits intocalcom:mainfrom
Vicolas11:main

Conversation

@Vicolas11
Copy link
Copy Markdown
Contributor

What does this PR do?

Cleanup duplicate DestinationCalendarSelector components

Fixes #7798

Environment: Staging(main branch) / Production

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

Press Ctrl+Shift+F and search for DestinationCalendarSelector

Checklist

  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@Vicolas11 Vicolas11 requested a review from a team March 22, 2023 13:23
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 22, 2023

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/getting-started/[[...step]] 303.22 KB 536.54 KB 153.30% (🟡 +0.07%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
ui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 31, 2023 at 9:00PM (UTC)

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 31, 2023

@emrysal is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@emrysal
Copy link
Copy Markdown
Contributor

emrysal commented Mar 31, 2023

Hi @Vicolas11 updated the DestinationCalendarSelectorComp to use the features one instead, looks that the new @features needed to use that one.

Copy link
Copy Markdown
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Vicolas11 - ready to go 🚀

@emrysal emrysal merged commit c052c66 into calcom:main Mar 31, 2023
@Vicolas11
Copy link
Copy Markdown
Contributor Author

Thanks @emrysal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CAL-1284] Cleanup destination calendar components

3 participants