Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@aar2dee2 is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
|
Hi, I'm using the Zoom integration as a reference for building the Webex integration. Screen.Recording.2023-03-09.at.5.24.17.PM.mov1/ I'm trying to test creating a meeting, but there's a Prisma error in the event types table. How should I fix this? 2/ I'm working on functionality for
Are any other functions required from the integration? 3/ Other TODOs |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Can you try running yarn clean && yarn dx in project root - looks like you might be missing a migration |
packages/app-store/webex/README.md
Outdated
| 6. Give your app a name. | ||
| 7. Upload an icon or choose one of the default icons. | ||
| 8. Give your app a short description. | ||
| 9. Set the Redirect URI as `<Cal.com URL>/api/integrations/webex/callback` replacing Cal.com URL with the URI at which your application runs. Also add the `<Cal.com URL>/api/auth/callback/webex` in Redirect URIs to allow authentication. |
There was a problem hiding this comment.
| 9. Set the Redirect URI as `<Cal.com URL>/api/integrations/webex/callback` replacing Cal.com URL with the URI at which your application runs. Also add the `<Cal.com URL>/api/auth/callback/webex` in Redirect URIs to allow authentication. | |
| 9. Set the Redirect URI as `<Cal.com URL>/api/integrations/webex/callback` replacing Cal.com URL with the URI at which your application runs. |
/auth/callback is not needed
hariombalhara
left a comment
There was a problem hiding this comment.
Yet to verify a change in the core booking flow
| const videoCredential = bookingToDelete.user.credentials.find( | ||
| (credential) => credential.id === credentialId | ||
| ); | ||
| const { credentialId, uid, type } = bookingVideoReference; |
There was a problem hiding this comment.
I reverted this entire file and was still able to cancel the webex meeting by cancelling the booking
There was a problem hiding this comment.
the cancel booking behavior is not consistent for me. I reverted the file to the original code and am running into errors again while canceling the booking. The videoAdapter is not picked correctly from credentials. This results in the meeting getting deleted on cal, but not on Webex. I added logs in a couple of places to show this.
There was a problem hiding this comment.
Thanks @aar2dee2. Looks like some weird problem. But as I see it, it has nothing to do with your app. Let's keep it reverted for this PR.
I would let @alannnc or @joeauyeung take care of it as they have more knowledge about this flow and this should be a problem with all video apps including Zoom in this case.
There was a problem hiding this comment.
okay. thanks!
any other recommended changes?
hariombalhara
left a comment
There was a problem hiding this comment.
LGTM now !! It is in a mergeable state. I see that console.logs are still there instead of logger but that can be a followup PR.
Regarding that change in handleCancelBooking, that's a core change which shoould be tackled separately.
|
thank you!! |
What does this PR do?
Fixes #2744
/claim #2744
Environment: Staging(main branch) / Production
Type of change
How should this be tested?
Checklist