Skip to content

[CAL-1094] Embed modal / Inline - UI/Layout/Spacing issues#7350

Merged
hariombalhara merged 5 commits intomainfrom
CALCOM-7155
Apr 3, 2023
Merged

[CAL-1094] Embed modal / Inline - UI/Layout/Spacing issues#7350
hariombalhara merged 5 commits intomainfrom
CALCOM-7155

Conversation

@gitstart-calcom
Copy link
Copy Markdown
Contributor

@gitstart-calcom gitstart-calcom commented Feb 24, 2023

What does this PR do?

Fixes #7155

Demo

Screenshot 2023-02-24 at 3 14 16 PM

Environment: Staging(main branch) / Production

@gitstart-calcom gitstart-calcom requested review from a team February 24, 2023 10:11
@linear
Copy link
Copy Markdown

linear bot commented Feb 24, 2023

CAL-1094 Embed modal / Inline - UI/Layout/Spacing issues

Current

CleanShot 2023-02-16 at 19.08.152x.png

Should be

CleanShot 2023-02-16 at 19.18.332x.png

View in Figma

Note: We might not need to touch the preview part. Mostly check spacing & components in the left panel, and ensure the modal doesn't touch the edges of the screen.

@PeerRich PeerRich requested a review from ciaranha February 24, 2023 10:45
CarinaWolli
CarinaWolli reviewed Feb 24, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@CarinaWolli CarinaWolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only left one small comment, other than that looks good to me 🙏

CarinaWolli
CarinaWolli approved these changes Feb 24, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@CarinaWolli CarinaWolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me, thank you 🙏

@gitstart-calcom
Copy link
Copy Markdown
Contributor Author

gitstart-calcom commented Mar 2, 2023

HI @CarinaWolli! #7156 is blocked by this PR because both are changes to the same component. Can we please get this PR merged soon?

@CarinaWolli
Copy link
Copy Markdown
Member

CarinaWolli commented Mar 2, 2023

need an approval from @calcom/ui

hariombalhara
hariombalhara reviewed Mar 9, 2023
View reviewed changes
hariombalhara
hariombalhara reviewed Mar 9, 2023
View reviewed changes
@hariombalhara
Copy link
Copy Markdown
Member

hariombalhara commented Mar 9, 2023 •
edited
Loading

@gitstart-calcom
Now:
Screenshot 2023-03-09 at 1 22 39 PM
The embed is showing up in Mobile mode now. There is no way to view desktop mode.

Production:
Screenshot 2023-03-09 at 1 24 13 PM

We need to have the width at least the bare minimum that is required to render in desktop mode

hariombalhara
hariombalhara requested changes Mar 9, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@hariombalhara hariombalhara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments

hariombalhara
hariombalhara reviewed Mar 9, 2023
View reviewed changes
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 20, 2023 •
edited
Loading

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 233.34 KB (🟡 +17 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/apps/[slug]/[...pages] 392.15 KB 625.49 KB 178.71% (🟢 -0.04%)
/event-types 349.11 KB 582.45 KB 166.41% (🟢 -0.04%)
/event-types/[type] 382.93 KB 616.27 KB 176.08% (🟢 -0.05%)
/settings/my-account/appearance 171.21 KB 404.55 KB 115.59% (🟢 -0.01%)
/settings/teams/[id]/appearance 171.23 KB 404.58 KB 115.59% (+/- <0.01%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@gitstart-calcom
Copy link
Copy Markdown
Contributor Author

gitstart-calcom commented Mar 20, 2023

Hi @hariombalhara, PR has been updated.

With current changes:
Screenshot 2023-03-20 at 4 54 41 PM

hariombalhara
hariombalhara reviewed Mar 21, 2023
View reviewed changes
hariombalhara
hariombalhara reviewed Mar 21, 2023
View reviewed changes
@deploysentinel
Copy link
Copy Markdown

deploysentinel bot commented Mar 22, 2023 •
edited
Loading

Current Playwright Test Results Summary

✅ 66 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 03/31/2023 05:55:09am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 18c941b

Started: 03/31/2023 05:49:18am UTC

⚠️ Flakes

📄   apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests user can add multiple organizer address
Retry 2 • Retry 1 • Initial Attempt
2.48% (4) 4 / 161 runs
failed over last 7 days
29.81% (48) 48 / 161 runs
flaked over last 7 days

View Detailed Build Results

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 28, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
cal ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 31, 2023 at 5:42AM (UTC)
dhe ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 31, 2023 at 5:42AM (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 31, 2023 at 5:42AM (UTC)

@gitstart-calcom
Copy link
Copy Markdown
Contributor Author

gitstart-calcom commented Mar 31, 2023

Hi @hariombalhara, we have made the requested changes. Please review the PR again 🙏

@hariombalhara hariombalhara merged commit 13a53c0 into main Apr 3, 2023
@hariombalhara hariombalhara deleted the CALCOM-7155 branch April 3, 2023 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hariombalhara hariombalhara hariombalhara approved these changes

@CarinaWolli CarinaWolli CarinaWolli approved these changes

@ciaranha ciaranha Awaiting requested review from ciaranha

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[CAL-1094] Embed modal / Inline - UI/Layout/Spacing issues

4 participants

@gitstart-calcom @CarinaWolli @hariombalhara @gitstart