Generate SSG Page used as cache for user's third-party calendar by roae · Pull Request #6775 · calcom/cal.com

roae · 2023-01-29T05:15:27Z

What does this PR do?

Generate a SSG page used as cache for user`s third-party calendars by month, this page revalidates each second.
tRCP getSchedule endpoint change: now get the generated json file for the SSG page which is normally used by NextJS in the browser navigation to get the third-party calendar data

TODO

Revalidate cache page when users connect/disconnect a calendar.
Revalidate when users change the selected calendars.
Revalidate when the user adds or deletes an event directly in the connected calendars via webhooks.
Add API endpoint to revalidates several months ahead.

Note: On development environment the response time of getSchedule endpoint increases because NextJS compiles the cache page first. To notice the improvement you must run a production build.

Type of change

Bug fix (non-breaking change which fixes an issue)
Chore (refactoring code, technical debt, workflow improvements)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

Checklist

I haven't read the contributing guide
My code doesn't follow the style guidelines of this project
I haven't checked if my PR needs changes to the documentation
I haven't checked if my changes generate no new warnings
I haven't added tests that prove my fix is effective or that my feature works
I haven't checked if new and existing unit tests pass locally with my changes

vercel · 2023-01-29T05:15:31Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
cal	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Feb 13, 2023 at 6:44PM (UTC)

1 Ignored Deployment

Name	Status	Preview	Comments	Updated
ui	⬜️ Ignored (Inspect)	Visit Preview		Feb 13, 2023 at 6:44PM (UTC)

vercel · 2023-01-29T05:15:32Z

@roae is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

zomars

Very clever approach. cc @emrysal can you take a look given a chance?

apps/web/package.json

packages/core/CalendarManager.ts

PeerRich · 2023-02-02T19:34:32Z

is this related to the RFC for caching calendars or is this unrelated?

zomars · 2023-02-02T19:47:29Z

is this related to the RFC for caching calendars or is this unrelated?

It is a different approach @PeerRich no need for a custom caldav server (at least not yet)

PeerRich · 2023-02-02T19:51:09Z

@roae can you uncommit your yarn.lock? (take it from our main)

roae · 2023-02-02T21:03:57Z

@roae can you uncommit your yarn.lock? (take it from our main)

Done!

zomars

Nitpicks. Will test properly on Monday

apps/web/pages/[user]/calendar-cache/[month].tsx

packages/core/CalendarManager.ts

Co-authored-by: Omar López <zomars@me.com>

into event_page_performance

* Cache fixes * Testing * SWR breaks embed tests

zomars

LFG!

PeerRich · 2023-02-10T21:20:33Z

HOLY SHIT 4s down to 240ms?!

zomars · 2023-02-10T21:23:10Z

HOLY SHIT 4s down to 240ms?!

Of course it varies between calls but still pretty impressive 🙌🏽

PeerRich

unfortunately there is a new skeleton loader that wasnt there on current prod

CleanShot.2023-02-10.at.22.28.19.mp4

zomars · 2023-02-10T21:51:39Z

unfortunately there is a new skeleton loader that wasnt there on current prod

CleanShot.2023-02-10.at.22.28.19.mp4

Adding more context to this change. We discovered that if a slot got taken and refetched it didn't disappear in the UI due the use of our local state. But agreed that we can improve the UX to match the previous one.

t3dotgg · 2023-02-11T08:32:09Z

I'm like 70% sure you can return from an API endpoint in Next with infinite cache times and not have to do the empty page hack - I do this all the time - revalidate works on API endpoints

zomars · 2023-02-13T18:12:16Z

I'm like 70% sure you can return from an API endpoint in Next with infinite cache times and not have to do the empty page hack - I do this all the time - revalidate works on API endpoints

Care to elaborate @t3dotgg ? Is this cache useful for every user or would it only work per browser/request?

zomars · 2023-02-13T18:30:56Z

unfortunately there is a new skeleton loader that wasnt there on current prod

CleanShot.2023-02-10.at.22.28.19.mp4

Skeleton got fixed

https://www.loom.com/share/4351b946528349dd87e201aa98bbca32

updated

zomars · 2023-02-13T18:38:32Z

Merging for now. We can always follow up with further improvements. Talked to @roae and it seems like the next big thing to solve would be reducing bundle size.

PeerRich · 2023-02-13T18:42:53Z

nice lets merge! should I or do you wanna click the magic green button

PeerRich · 2023-02-13T18:43:05Z

whopsy wrong button clicky

zomars · 2023-02-13T18:43:52Z

leventdeniz · 2023-02-21T10:19:34Z

Talked to @roae and it seems like the next big thing to solve would be reducing bundle size.

I searched the current main. There are a few cases where the entire lodash is being imported for no reason. Should be a very easy fix that instantly reduces bundle size.

Did this in another project the other day, before/after:

PeerRich · 2023-02-21T11:02:21Z

i think we can get rid of lodash alltogether no? most of lodash is ECMA specs now anyway

Generate SSG Page used as cache for user's third-party calendars

902279c

algora-pbc bot mentioned this pull request Jan 29, 2023

[CAL-119] Initial rendering of calendar takes 3-5 seconds! #4535

Closed

zomars reviewed Jan 29, 2023

View reviewed changes

apps/web/package.json Outdated Show resolved Hide resolved

packages/core/CalendarManager.ts Show resolved Hide resolved

vercel bot deployed to Preview – cal January 29, 2023 06:09 View deployment

PeerRich requested a review from emrysal January 29, 2023 09:20

roae added 2 commits February 2, 2023 13:45

remove next-build-id dependency

750a4c2

yarn.lock from main

46b3ffe

Merge branch 'main' into pr/6775

d1fe6d1

vercel bot had a problem deploying to Preview – ui February 2, 2023 21:30 Failure

zomars reviewed Feb 2, 2023

View reviewed changes

apps/web/pages/[user]/calendar-cache/[month].tsx Outdated Show resolved Hide resolved

apps/web/pages/[user]/calendar-cache/[month].tsx Outdated Show resolved Hide resolved

packages/core/CalendarManager.ts Outdated Show resolved Hide resolved

vercel bot deployed to Preview – cal February 2, 2023 22:52 View deployment

roae and others added 5 commits February 2, 2023 20:25

add support to get cached data from multiple months

77d8405

Update apps/web/pages/[user]/calendar-cache/[month].tsx

1f85dae

Co-authored-by: Omar López <zomars@me.com>

Update apps/web/pages/[user]/calendar-cache/[month].tsx

76eaf89

Co-authored-by: Omar López <zomars@me.com>

Update packages/core/CalendarManager.ts

eb94f0c

Co-authored-by: Omar López <zomars@me.com>

Merge branch 'event_page_performance' of https://github.com/roae/cal.com

12a9e46

into event_page_performance

zomars mentioned this pull request Feb 8, 2023

[CAL-928] RFC: User availability caching #6710

Closed

roae added 7 commits February 8, 2023 12:22

Add api endpoint that revalidates the current month and 3 more ahead

c75ac14

Revalidate calendar cache when user connect new calendar.

8dc5d47

Revalidate calendar cache when user remove a calendar.

a0c81eb

Revalidate calendar cache when user change de selected calendars-

fb2412b

Change revalidateCalendarCache function to @calcom/lib/server

2a386e4

Remove the memory cache from getCachedResults

ae73393

refetch availability slots in a 3 seconds interval

0d39452

zomars added 3 commits February 10, 2023 14:07

Merge branch 'main' into pr/6775

17c374e

Fixes/trpc headers (calcom#7045)

56f32d0

* Cache fixes * Testing * SWR breaks embed tests

Merge branch 'main' into pr/6775

418306d

zomars approved these changes Feb 10, 2023

View reviewed changes

vercel bot had a problem deploying to Preview – cal February 10, 2023 21:23 Failure

PeerRich previously requested changes Feb 10, 2023

View reviewed changes

Prevent refetching day on month switch

5da47dd

vercel bot had a problem deploying to Preview – cal February 10, 2023 22:14 Failure

roae force-pushed the event_page_performance branch from 8b074b0 to 5da47dd Compare February 13, 2023 03:42

Merge branch 'calcom:main' into event_page_performance

33a1584

vercel bot deployed to Preview – ui February 13, 2023 03:48 View deployment

Skeleton fixes

0f13639

zomars requested a review from PeerRich February 13, 2023 18:10

zomars mentioned this pull request Feb 13, 2023

fix: remove local slot caching #7071

Closed

3 tasks

PeerRich closed this Feb 13, 2023

zomars merged commit afb9605 into calcom:main Feb 13, 2023

vercel bot deployed to Preview – cal February 13, 2023 18:44 View deployment

Conversation

roae commented Jan 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Type of change

Checklist

Uh oh!

vercel bot commented Jan 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel bot commented Jan 29, 2023

Uh oh!

zomars left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

PeerRich commented Feb 2, 2023

Uh oh!

zomars commented Feb 2, 2023

Uh oh!

PeerRich commented Feb 2, 2023

Uh oh!

roae commented Feb 2, 2023 • edited by zomars Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zomars left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zomars left a comment

Choose a reason for hiding this comment

Uh oh!

PeerRich commented Feb 10, 2023

Uh oh!

zomars commented Feb 10, 2023

Uh oh!

PeerRich left a comment

Choose a reason for hiding this comment

Uh oh!

zomars commented Feb 10, 2023

Uh oh!

t3dotgg commented Feb 11, 2023

Uh oh!

zomars commented Feb 13, 2023

Uh oh!

zomars commented Feb 13, 2023

Uh oh!

zomars commented Feb 13, 2023

Uh oh!

PeerRich commented Feb 13, 2023

Uh oh!

PeerRich commented Feb 13, 2023

Uh oh!

zomars commented Feb 13, 2023

Uh oh!

leventdeniz commented Feb 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PeerRich commented Feb 21, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

roae commented Jan 29, 2023 •

edited

Loading

vercel bot commented Jan 29, 2023 •

edited

Loading

roae commented Feb 2, 2023 •

edited by zomars

Loading

leventdeniz commented Feb 21, 2023 •

edited

Loading