feat: add sylaps into the app-store in video category#6728
feat: add sylaps into the app-store in video category#6728hariombalhara merged 21 commits intocalcom:mainfrom
Conversation
|
@hthetiot is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I think codacy failure is wrong, i have checked other DESCRIPTION files they use 2 spaces.
|
|
I might need so also implement this changes in sylaps listing https://github.com/calcom/cal.com/pull/6712/files |
|
merged main to fix CI |
📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! Sixty-eight Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
|
bear with me, our CI is currently borked, just switched to a new Github workflows. I think your PR is fine, I just wanna wait for the green check marks to come back |
zomars
left a comment
There was a problem hiding this comment.
Just tested this locally and stumbled upon this case.
The success page says: "Sylaps: Meeting url is in the confirmation email"
But the the confirmation email just says "Sylaps":
No link is there whatsoever
|
Have fixed the issue reported by @zomars locally, but can't push the fix. @hthetiot can you allow edits on the PR from maintainers. See https://github.com/calcom/cal.com/blob/main/CONTRIBUTING.md#:~:text=Be%20sure%20to%20check%20the%20%22Allow%20edits%20from%20maintainers%22%20option%20while%20creating%20you%20PR. The changes that I have done, I have already added in PR description. |
Will do, thx, keep you posted. |
|
hey @hthetiot were the changes applied? happy to merge this week |
Sorry need more time, I will attempt to finish PR next week. |
…store/sylapsvideo: This package doesn't seem to be present in your lockfile; run yarn install to update the lockfile
fixed |
Actually, having or not having that file makes no difference functionally. Every App automatically uses a common InstallAppButton component. It is a legacy file(wouldn't have come if you used App Store Cli to create the app) which probably came because you copied it from an old app(pre AppStore Cli) |
|
This PR currently has a merge conflict. Please resolve this and then re-add the |
…tallAppButton|index).tsx
deleted |
|
Thx @hariombalhara for merge. |
|
@hariombalhara I can see the PR is deployed on cal.com via the file https://app.cal.com/app-store/sylapsvideo/icon.svg but I don't see Sylaps in the application store , would it be possible to enable it? Once done I will add Cal.com info on sylaps.com ;) |
|
@hthetiot There is an issue at the moment in enabling the app. I would let you know once it resolves |
@hariombalhara |
What does this PR do?
Add Sylaps (aka https://Sylaps.com) video conference service to the Apps.
Type of change
How should this be tested?
Changes by @hariombalhara
dirNamefromslug.appMetaDeta.ts