Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
|
@joeshajan is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
emrysal
left a comment
There was a problem hiding this comment.
Tagging @Jaibles - but looking at this it looks good, only thing I can spot is that the font used for "No data yet." should be the SF Mono font. This is just the Mac OSX default so you can add
| )} | ||
| </div> | ||
| </div> | ||
| <div className="rounded-b-md bg-black p-4 text-xs text-white"> |
There was a problem hiding this comment.
Tagging @Jaibles - but looking at this it looks good, only thing I can spot is that the font used for "No data yet." should be the SF Mono font. This is just the Mac OSX default so you can add font-mono to achieve this.
|
Hey @emrysal can you check if this is correct? |
CarinaWolli
left a comment
There was a problem hiding this comment.
I found some design issues and added suggestions @joeshajan can you please take a look at that, make sure to use the figma design to compare if all font sizes, weights and line heights are as they should. Thank you 🙏
packages/features/webhooks/components/WebhookTestDisclosure.tsx
Outdated
Show resolved
Hide resolved
| <div className="flex justify-between"> | ||
| <div> | ||
| <p className="font-medium text-black">{t("webhook_test")}</p> | ||
| <p className="font-sm mb-4 text-gray-600">{t("test_webhook")}</p> |
There was a problem hiding this comment.
| <p className="font-sm mb-4 text-gray-600">{t("test_webhook")}</p> | |
| <p className="mb-4 text-sm font-normal text-gray-500">{t("test_webhook")}</p> |
There was a problem hiding this comment.
@joeshajan Sorry that's right 👍 still font-sm should be text-sm here
packages/features/webhooks/components/WebhookTestDisclosure.tsx
Outdated
Show resolved
Hide resolved
packages/features/webhooks/components/WebhookTestDisclosure.tsx
Outdated
Show resolved
Hide resolved
packages/features/webhooks/components/WebhookTestDisclosure.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Carina Wollendorfer <30310907+CarinaWolli@users.noreply.github.com>
Co-authored-by: Carina Wollendorfer <30310907+CarinaWolli@users.noreply.github.com>
Co-authored-by: Carina Wollendorfer <30310907+CarinaWolli@users.noreply.github.com>
Co-authored-by: Carina Wollendorfer <30310907+CarinaWolli@users.noreply.github.com>
Co-authored-by: Carina Wollendorfer <30310907+CarinaWolli@users.noreply.github.com>
b337c7b to
3928a42
Compare
|
Hey, @CarinaWolli and @emrysal I'm closing this pull request as I messed up when merging the main branch. So I'm closing this PR and raising a new one #6803 with all the changes mentioned here. |
What does this PR do?
Fixes #6414
These are the changes I made.
In the Figma file, the font weight and colour look different visually but the values are the same. I need more clarification about wether I should change it or not.
And also all the other colours are also the same.
Currently, this is the heading, but in Figma the back arrow is outside. But when I try to change it, it will affect other places also. So should I go with it or keep it as it is?
Type of change
How should this be tested?