Skip to content

Add disable success page config[Platform Only]#6225

Merged
kodiakhq[bot] merged 4 commits intomainfrom
hariom/cal-340-toggle-to-disable-success-page-when
Jan 2, 2023
Merged

Add disable success page config[Platform Only]#6225
kodiakhq[bot] merged 4 commits intomainfrom
hariom/cal-340-toggle-to-disable-success-page-when

Conversation

@hariombalhara
Copy link
Copy Markdown
Member

@hariombalhara hariombalhara commented Dec 30, 2022

What does this PR do?

Fixes #5446

Demo -> https://www.loom.com/share/5f24ebce4ada49c785bdd6e086ebe7da

Environment: Production

Type of change

  • New feature (non-breaking change which adds functionality)

How should this be tested?

  • Test A
  • Test B

Checklist

  • I haven't added tests that prove my fix is effective or that my feature works

@linear
Copy link
Copy Markdown

linear bot commented Dec 30, 2022

CAL-340 Toggle to disable success page when success redirect is enabled

When using the event "redirect" feature to another website, the redirect shows the confirmation page still then goes to the redirect, is it possible to add a toggle to disable showing the confirmation page

— Requested by a customer

cc @shiraz

From SyncLinear.com

@vercel
Copy link
Copy Markdown

vercel bot commented Dec 30, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ❌ Failed (Inspect) Jan 2, 2023 at 8:40AM (UTC)

@hariombalhara hariombalhara changed the title Add disable success page config Add disable success page config[Self Hosted Only] Dec 30, 2022
@hariombalhara hariombalhara force-pushed the hariom/cal-340-toggle-to-disable-success-page-when branch from ccf9d3a to 42cde2a Compare January 1, 2023 08:09
@github-actions github-actions bot added automerge ♻️ autoupdate tells kodiak to keep this branch up-to-date labels Jan 1, 2023
@hariombalhara hariombalhara force-pushed the hariom/cal-340-toggle-to-disable-success-page-when branch from 072fa57 to ca29da5 Compare January 1, 2023 08:18
@hariombalhara hariombalhara marked this pull request as ready for review January 1, 2023 08:18
@hariombalhara hariombalhara requested a review from a team January 1, 2023 08:25
Copy link
Copy Markdown
Member Author

@hariombalhara hariombalhara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self reviewed

{...rest}
ref={ref}
type="checkbox"
disabled={disabled}
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disabled support was missing in native checkbox

/>
</div>
<span className="text-sm ltr:ml-3 rtl:mr-3">{description}</span>
<span className="text-sm">{description}</span>
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before:
Screenshot 2023-01-01 at 1 35 42 PM

After:
Screenshot 2023-01-01 at 1 36 20 PM

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look a lot better 🙏

@kodiakhq
Copy link
Copy Markdown
Contributor

kodiakhq bot commented Jan 1, 2023

This PR currently has a merge conflict. Please resolve this and then re-add the automerge label.

@kodiakhq kodiakhq bot removed the automerge label Jan 1, 2023
@hariombalhara hariombalhara force-pushed the hariom/cal-340-toggle-to-disable-success-page-when branch from 0336139 to 5cfd0fb Compare January 2, 2023 01:26
@kodiakhq
Copy link
Copy Markdown
Contributor

kodiakhq bot commented Jan 2, 2023

This PR currently has a merge conflict. Please resolve this and then re-add the automerge label.

@kodiakhq kodiakhq bot removed the automerge label Jan 2, 2023
@hariombalhara hariombalhara changed the title Add disable success page config[Self Hosted Only] Add disable success page config[Platform Only] Jan 2, 2023
@kodiakhq kodiakhq bot merged commit 15123c1 into main Jan 2, 2023
@kodiakhq kodiakhq bot deleted the hariom/cal-340-toggle-to-disable-success-page-when branch January 2, 2023 08:41
@aasargsian
Copy link
Copy Markdown

@hariombalhara Could you pls kindly check out a related bug: #6497

@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge ♻️ autoupdate tells kodiak to keep this branch up-to-date core area: core, team members only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CAL-340] Toggle to disable success page when success redirect is enabled

4 participants