Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| "impersonate_user_tip": "All uses of this feature is audited.", | ||
| "impersonating_user_warning": "Impersonating username \"{{user}}\".", | ||
| "impersonating_stop_instructions": "<0>Click Here to stop</0>.", | ||
| "impersonating_stop_instructions": "Click here to stop", |
There was a problem hiding this comment.
Was not being used, so I corrected format and used it
| logger.error("Could not add this caldav account", e); | ||
| if (e instanceof Error) { | ||
| let message = e.message; | ||
| if (e.message.indexOf("Invalid credentials") > -1 && url.indexOf("dav.php") > -1) { |
There was a problem hiding this comment.
If we know it is baikal and the error is "Invalid credentials", then we introduce the hint
There was a problem hiding this comment.
nit: .includes is easier to eyes :D
There was a problem hiding this comment.
nit: Might be a good idea to make an abstraction like isBaikal. That would not require any comment and in future too it would be clear what's going on
| target="_blank" | ||
| className="ml-5 w-32 !p-5"> | ||
| Go to Admin | ||
| </Button> |
There was a problem hiding this comment.
Providing a button to easily go to the Baikal Admin page to change the wrong value
hariombalhara
left a comment
There was a problem hiding this comment.
Looks good, only nits are there.
| logger.error("Could not add this caldav account", e); | ||
| if (e instanceof Error) { | ||
| let message = e.message; | ||
| if (e.message.indexOf("Invalid credentials") > -1 && url.indexOf("dav.php") > -1) { |
There was a problem hiding this comment.
nit: Might be a good idea to make an abstraction like isBaikal. That would not require any comment and in future too it would be clear what's going on
| "//" + | ||
| parsedUrl.hostname + | ||
| (parsedUrl.port ? ":" + parsedUrl.port : "") + | ||
| "/admin/?/settings/standard/"; |
There was a problem hiding this comment.
nit: Can be simplified as ${parsedUrl.origin}/admin/?/settings/standard
| severity="error" | ||
| title={errorMessage} | ||
| actions={ | ||
| errorActionUrl !== "" ? ( |
|
Agreed with @hariombalhara NITs. Specially for the code readability suggestions (adding the isBaikal check) |
|
@hariombalhara @alishaz-polymath thanks for your feedback, will tackle on a follow up PR soon enough |
What does this PR do?
Introduces a better error message when adding CalDAV Baikal integration, which according to #588 it's due to the wrong WebDAV authentication type.
Fixes #588
Environment: Staging(main branch) / Production
Type of change
How should this be tested?
Checklist