Skip to content

Adds support for .eml calendar objects#4815

Merged
pumfleet merged 1 commit intomainfrom
fix/cal-dav-fetch-object
Oct 4, 2022
Merged

Adds support for .eml calendar objects#4815
pumfleet merged 1 commit intomainfrom
fix/cal-dav-fetch-object

Conversation

@alishaz-polymath
Copy link
Copy Markdown
Member

@alishaz-polymath alishaz-polymath commented Oct 4, 2022

What does this PR do?

Adds a custom URL Filter for extended support formats, currently accepting .eml and .ics only, but opens a potential to use more in the future, as needs come up.

Fixes #4003 #1588

Loom Video

Environment: Staging(main branch)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@alishaz-polymath alishaz-polymath self-assigned this Oct 4, 2022
@vercel
Copy link
Copy Markdown

vercel bot commented Oct 4, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Oct 4, 2022 at 8:05AM (UTC)

@alishaz-polymath alishaz-polymath added 🐛 bug Something isn't working ✨ feature New feature or request labels Oct 4, 2022
@alishaz-polymath alishaz-polymath requested review from a team, emrysal and hariombalhara October 4, 2022 08:16
pumfleet
pumfleet approved these changes Oct 4, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@pumfleet pumfleet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me

@pumfleet pumfleet merged commit 369d7c4 into main Oct 4, 2022
@pumfleet pumfleet deleted the fix/cal-dav-fetch-object branch October 4, 2022 09:02
@alishaz-polymath alishaz-polymath linked an issue Oct 4, 2022 that may be closed by this pull request
Busy booked events from CalDav (NextCloud) & Apple don't block scheduling availability #1588
Closed
@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pumfleet pumfleet pumfleet approved these changes

@emrysal emrysal Awaiting requested review from emrysal

@hariombalhara hariombalhara Awaiting requested review from hariombalhara

Assignees

@alishaz-polymath alishaz-polymath

Labels

🐛 bug Something isn't working core area: core, team members only ✨ feature New feature or request

Projects

No open projects
Cal.com Core Roadmap
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Events created on Kerio not pulled (CalDAV) Busy booked events from CalDav (NextCloud) & Apple don't block scheduling availability

3 participants

@alishaz-polymath @pumfleet @PeerRich