Skip to content

Feat Booking Limits#4759

Merged
PeerRich merged 60 commits intomainfrom
feat/booking-limits-v2
Oct 12, 2022
Merged

Feat Booking Limits#4759
PeerRich merged 60 commits intomainfrom
feat/booking-limits-v2

Conversation

@sean-brydon
Copy link
Copy Markdown
Member

@sean-brydon sean-brydon commented Sep 29, 2022

What does this PR do?

UI

CleanShot 2022-10-04 at 12 56 07

Backend Stuff
https://www.loom.com/share/d6c01ec823554d2094b377dda87449e7

Fixes #2684

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • run tests
  • add limits
  • check bookings are blocked

@vercel
Copy link
Copy Markdown

vercel bot commented Sep 29, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Oct 12, 2022 at 5:23AM (UTC)

@sean-brydon sean-brydon changed the title Add db relevant stuff Feat Booking Limits Sep 29, 2022
@PeerRich
Copy link
Copy Markdown
Member

can't wait for this

zomars
zomars previously requested changes Oct 10, 2022
Copy link
Copy Markdown
Contributor

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking since there are some type check errors

image

@PeerRich
Copy link
Copy Markdown
Member

@zomars, @sean-brydon is OOO for 7 days. should someone else fix those?

@zomars
Copy link
Copy Markdown
Contributor

zomars commented Oct 10, 2022

@zomars, @sean-brydon is OOO for 7 days. should someone else fix those?

@alannnc said he would take this one

Copy link
Copy Markdown
Contributor

@alannnc alannnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now type checks pass and functionality works as expected. Should be ready to test it on cal.dev before going to production.

@hariombalhara
Copy link
Copy Markdown
Member

Resolved Deployment issue. Should be merged automatically now.

@PeerRich PeerRich merged commit 5293db2 into main Oct 12, 2022
@PeerRich PeerRich deleted the feat/booking-limits-v2 branch October 12, 2022 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants