Hotfix: Be more strict with safeRedirectUrl check#4675
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
emrysal
requested changes
Sep 23, 2022
hariombalhara
commented
Sep 24, 2022
| throw new Error("Pass an absolute URL"); | ||
| } | ||
|
|
||
| const urlParsed = new URL(url); |
Member
Author
There was a problem hiding this comment.
safe to parse with URL because earlier check has ensured it is an absolute URL
Co-authored-by: Alex van Andel <me@alexvanandel.com>
emrysal
approved these changes
Sep 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It assumes that the following URLs are in this format https://example.com (which is origin of a website) . .env.example confirms it. But if someone has accidentally used something like https://example.com/ (note terminating slash), then safeRedirectUrl would return WebApp URL.
CONSOLE_URL
WEBAPP_URL
WEBSITE_URL
For more details refer to internal thread: https://twist.com/a/195135/ch/589886/t/3786075/