Skip to content

feat: optimistically update when deleting an availability#4648

Merged
emrysal merged 7 commits intocalcom:mainfrom
G3root:optimistic-update
Sep 21, 2022
Merged

feat: optimistically update when deleting an availability#4648
emrysal merged 7 commits intocalcom:mainfrom
G3root:optimistic-update

Conversation

@G3root
Copy link
Copy Markdown
Contributor

@G3root G3root commented Sep 21, 2022

What does this PR do?

this PR adds a feature to optimistically update the state when deleting an availability.
https://www.loom.com/share/b8cb626c752b44c0bf8847584ee8caef

Environment: Staging(main branch) / Production

Type of change

  • New feature (non-breaking change which adds functionality)

@vercel
Copy link
Copy Markdown

vercel bot commented Sep 21, 2022

@G3root is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@PeerRich PeerRich requested a review from emrysal September 21, 2022 15:41
@PeerRich
Copy link
Copy Markdown
Member

this looks great, we should delete and update all items optimistically (also re-ordering of event-types).

@emrysal will review and leave feedback

@vercel
Copy link
Copy Markdown

vercel bot commented Sep 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Sep 21, 2022 at 9:13PM (UTC)

@emrysal
Copy link
Copy Markdown
Contributor

emrysal commented Sep 21, 2022

Looks great from my end @G3root - very nice with the animations too

@emrysal emrysal enabled auto-merge (squash) September 21, 2022 18:14
@emrysal emrysal added the ♻️ autoupdate tells kodiak to keep this branch up-to-date label Sep 21, 2022
@emrysal emrysal merged commit f14b13a into calcom:main Sep 21, 2022
@G3root G3root deleted the optimistic-update branch September 22, 2022 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge ♻️ autoupdate tells kodiak to keep this branch up-to-date

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants