Skip to content

Mobile: hide bottom nav on any sub page#4626

Merged
PeerRich merged 2 commits intocalcom:mainfrom
gitstart:CAL-267
Sep 21, 2022
Merged

Mobile: hide bottom nav on any sub page#4626
PeerRich merged 2 commits intocalcom:mainfrom
gitstart:CAL-267

Conversation

@gitstart
Copy link
Copy Markdown
Contributor

@gitstart gitstart commented Sep 20, 2022 •
edited
Loading

What does this PR do?

Fixes #4398

Demo

https://www.loom.com/share/6e2515af595e4b66b8505f5618dc1178

Environment: Staging(main branch) / Production

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@gitstart @niteshsingh1357
@matheusmuniz03 @gracebir @seunexplicit @Thiagomn1
Mobile: hide bottom nav on any sub page
79d1730 
Co-authored-by: Nitesh Singh <nitesh.singh@gitstart.dev>
Co-authored-by: gitstart <gitstart@users.noreply.github.com>
Co-authored-by: Matheus Muniz <87545749+matheusmuniz03@users.noreply.github.com>
Co-authored-by: hustle-ps <grace.devolop@gmail.com>
Co-authored-by: Olusanya Timothy <48022904+seunexplicit@users.noreply.github.com>
Co-authored-by: Thiago Nascimbeni <tnascimbeni@gmail.com>
@vercel
Copy link
Copy Markdown

vercel bot commented Sep 20, 2022

@gitstart is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link
Copy Markdown

vercel bot commented Sep 21, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Sep 21, 2022 at 3:34PM (UTC)

PeerRich
PeerRich approved these changes Sep 21, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@PeerRich PeerRich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work, thank you!

@PeerRich PeerRich enabled auto-merge (squash) September 21, 2022 15:39
@PeerRich PeerRich disabled auto-merge September 21, 2022 15:39
@PeerRich PeerRich merged commit 7d1065d into calcom:main Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PeerRich PeerRich PeerRich approved these changes

@ciaranha ciaranha Awaiting requested review from ciaranha

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Mobile: hide bottom nav on any sub page

2 participants

@gitstart @PeerRich