fix-connect-calendar-minor-issues#4586
Merged
kodiakhq[bot] merged 7 commits intomainfrom Sep 22, 2022
Merged
Conversation
… from calendar, added redirect on SSR for installed/calendar page
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alannnc
commented
Sep 19, 2022
| } | ||
|
|
||
| // Server side rendering | ||
| export async function getServerSideProps(ctx: AppGetServerSidePropsContext) { |
alannnc
commented
Sep 19, 2022
| {/* Already connected calendars */} | ||
| {firstCalendar && | ||
| {!queryConnectedCalendars.isLoading && | ||
| firstCalendar && |
Contributor
Author
There was a problem hiding this comment.
This will prevent that calendar list displays while trpc is loading
pumfleet
approved these changes
Sep 19, 2022
Contributor
pumfleet
left a comment
There was a problem hiding this comment.
Code looks good to me, haven't tested
…ement based on cookie
…' into fix/connect-calendar-redirect-v2
ceda3b7 to
31f2496
Compare
hariombalhara
approved these changes
Sep 22, 2022
| }; | ||
| }; | ||
|
|
||
| export const getStaticPaths: GetStaticPaths = () => { |
Member
There was a problem hiding this comment.
cc @leog. This has to go because of SSR requirement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes # (issue)
How should this be tested?
Checklist