Skip to content

Use PremiumTextField in v2#4577

Merged
kodiakhq[bot] merged 19 commits intomainfrom
add-premium-text-field-input-back
Sep 22, 2022
Merged

Use PremiumTextField in v2#4577
kodiakhq[bot] merged 19 commits intomainfrom
add-premium-text-field-input-back

Conversation

@hariombalhara
Copy link
Copy Markdown
Member

@hariombalhara hariombalhara commented Sep 18, 2022 •
edited
Loading

  • Use PremiumTextField in V2 profile again
  • V2 UI fixes as well for PremiumTextField component
  • If a user is premium or not, this info is obtained from stripe only now from stripe customer metadata. This was part of previous PR merge related to signup.
    Loom

Important

In current flow, if a username is already premium it is assumed that

  • The user might have already paid for it or
  • He has been given premium username for free(like a DB update).

So, short usernames that are in our seed are considered Premium and they don't require payment to change to a new premium username. This is the reason @alannnc that for pro username it wasn't considering it as an upgrade when you try to choose a premium username.
This was done because I analyzed some of the metadata that we have in DB and found out that some of the premium usernames don't have user.metadata.isPremium set to true. It might be due to the reason that user.metadata.isPremium logic might have been added later on

Follow up

  • Show proper inline messages on successful payment or a failure in payment. They were working earlier but broken in V2, will figure out what needs changing.

@vercel
Copy link
Copy Markdown

vercel bot commented Sep 18, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Sep 22, 2022 at 5:31PM (UTC)

@hariombalhara hariombalhara force-pushed the add-premium-text-field-input-back branch from c3a8497 to 8bdf435 Compare September 18, 2022 14:10
@hariombalhara hariombalhara added the ♻️ autoupdate tells kodiak to keep this branch up-to-date label Sep 18, 2022
alannnc
alannnc reviewed Sep 18, 2022
View reviewed changes
@PeerRich PeerRich removed the ♻️ autoupdate tells kodiak to keep this branch up-to-date label Sep 19, 2022
zomars
zomars approved these changes Sep 22, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it

@zomars zomars added ♻️ autoupdate tells kodiak to keep this branch up-to-date automerge labels Sep 22, 2022
@kodiakhq kodiakhq bot merged commit ace27ca into main Sep 22, 2022
@kodiakhq kodiakhq bot deleted the add-premium-text-field-input-back branch September 22, 2022 17:34
@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emrysal emrysal emrysal left review comments

+2 more reviewers

@alannnc alannnc alannnc left review comments

@zomars zomars zomars approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

automerge ♻️ autoupdate tells kodiak to keep this branch up-to-date core area: core, team members only

Projects

No open projects
Cal.com Core Roadmap
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@hariombalhara @emrysal @zomars @alannnc @PeerRich @joeauyeung