Skip to content

Routing Forms Improvements - Rename routing_forms to routing-forms#4546

Merged
hariombalhara merged 20 commits intomainfrom
routing-form-improvements
Sep 22, 2022
Merged

Routing Forms Improvements - Rename routing_forms to routing-forms#4546
hariombalhara merged 20 commits intomainfrom
routing-form-improvements

Conversation

@hariombalhara
Copy link
Copy Markdown
Member

@hariombalhara hariombalhara commented Sep 17, 2022 •
edited
Loading

What does this PR do?

Fixes #4074

  • Also, adds autoAnimate to the Fields list and Routes list.
  • Found the following bugs, during webhooks testing. These are also fixed.

Screenshot 2022-09-22 at 10 28 19 AM

- I had expected webhook tests to catch the bugs in the webhook flow, but they weren't running. Have enabled them again.

Environment: Production

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Install the Routing Forms App.
  • Add a Form and Preview it.
  • Add a FORM_SUBMITTED webhook and test it

Checklist

  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@vercel
Copy link
Copy Markdown

vercel bot commented Sep 17, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Sep 22, 2022 at 5:00PM (UTC)

@hariombalhara hariombalhara changed the title Animate fields list and routes list Routing Forms Improvements Sep 17, 2022
@hariombalhara hariombalhara changed the title Routing Forms Improvements Routing Forms Improvements - Rename routing_forms to routing-forms Sep 20, 2022
@hariombalhara hariombalhara requested a review from a team September 20, 2022 11:11
zomars
zomars suggested changes Sep 21, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are some slugs missing still @hariombalhara

image

@hariombalhara
Copy link
Copy Markdown
Member Author

hariombalhara commented Sep 22, 2022 •
edited
Loading

Thank you so much @zomars 🙏 I am not sure how I missed those. I have fixed them.

There are still certain search results for routing_forms which I have kept intentionally.
Screenshot 2022-09-22 at 10 55 28 AM

@hariombalhara hariombalhara added the ♻️ autoupdate tells kodiak to keep this branch up-to-date label Sep 22, 2022
@hariombalhara hariombalhara force-pushed the routing-form-improvements branch from 7b5fd44 to ca00dd0 Compare September 22, 2022 05:31
@hariombalhara hariombalhara force-pushed the routing-form-improvements branch from 75d64e1 to 386f9fb Compare September 22, 2022 10:12
@hariombalhara hariombalhara force-pushed the routing-form-improvements branch 2 times, most recently from ff4aeed to 03ebf13 Compare September 22, 2022 10:22
@hariombalhara hariombalhara force-pushed the routing-form-improvements branch from 03ebf13 to 1a46e9f Compare September 22, 2022 10:25
@hariombalhara hariombalhara merged commit ce41397 into main Sep 22, 2022
@hariombalhara hariombalhara deleted the routing-form-improvements branch September 22, 2022 17:23
@CarinaWolli CarinaWolli mentioned this pull request Sep 27, 2022
Closed
@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@zomars zomars zomars approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

♻️ autoupdate tells kodiak to keep this branch up-to-date core area: core, team members only

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Hover shouldn't be required to show Event in Webhook > NIT: can we also change routing_forms to routing-forms?

3 participants

@hariombalhara @zomars @PeerRich