Skip to content

Fix flash of untranslated content by adding inline Skeleton Loaders on EventType#4519

Merged
PeerRich merged 6 commits intomainfrom
misc-fixes
Sep 21, 2022
Merged

Fix flash of untranslated content by adding inline Skeleton Loaders on EventType#4519
PeerRich merged 6 commits intomainfrom
misc-fixes

Conversation

@hariombalhara
Copy link
Copy Markdown
Member

@hariombalhara hariombalhara commented Sep 16, 2022 •
edited
Loading

What does this PR do?

Fixes #4512

  • Adds skeleton loading for Event Setup and advanced tabs - Loom - Will add skeletons for more pages once this approach is accepted cc @zomars
  • Also adds a new Skeleton component that makes it easy to add skeletons inline

Environment:Production

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • Test A
  • Test B

Checklist

  • I haven't added tests that prove my fix is effective or that my feature works

@vercel
Copy link
Copy Markdown

vercel bot commented Sep 16, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Sep 21, 2022 at 3:56PM (UTC)

@hariombalhara hariombalhara requested a review from a team September 16, 2022 08:51
@hariombalhara hariombalhara marked this pull request as ready for review September 16, 2022 08:51
@hariombalhara hariombalhara changed the title Fix flash of untranslated content, Event Types tab not highlighted when editing an Event Type Fix flash of untranslated content on EventType Sep 20, 2022
@hariombalhara hariombalhara changed the title Fix flash of untranslated content on EventType Fix flash of untranslated content by adding inline Skeleton Loaders on EventType Sep 20, 2022
PeerRich
PeerRich approved these changes Sep 21, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@PeerRich PeerRich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a really great idea to have a generic Skeleton component

@PeerRich PeerRich enabled auto-merge (squash) September 21, 2022 15:48
@PeerRich PeerRich merged commit 631e974 into main Sep 21, 2022
@PeerRich PeerRich deleted the misc-fixes branch September 21, 2022 16:01
@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PeerRich PeerRich PeerRich approved these changes

@sean-brydon sean-brydon Awaiting requested review from sean-brydon

Assignees

No one assigned

Labels

core area: core, team members only

Projects

No open projects
Cal.com Core Roadmap
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Flash of Untranslated content on event-type view

2 participants

@hariombalhara @PeerRich