fix: lazy-load companion iframe to avoid requests on every page visit#27946
Merged
fix: lazy-load companion iframe to avoid requests on every page visit#27946
Conversation
Co-Authored-By: Volnei Munhoz <volnei.munhoz@gmail.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
PeerRich
approved these changes
Feb 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The companion Chrome extension's content script runs on
<all_urls>and was immediately settingiframe.src = "https://companion.cal.com"on every page load — even though the sidebar starts hidden. This caused a network request tocompanion.cal.comon every page the user visits.This PR defers setting
iframe.srcuntil the user actually opens the sidebar (via icon click, integration trigger, or auto-open). The iframe element is still created at page load (pointing toabout:blank), but no network request is made until needed.Changes:
iframeLoadedflag to track whether the iframe has been initializediframe.src = COMPANION_URLfrom initializationiframe.srclazily insideopenSidebar()on first callmessageevent listener with an early return when iframe hasn't loaded (preventsnew URL(iframe.src)from throwing on empty string)Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
npm run ext:buildincompanion/)example.com) — open DevTools Network tab and confirm no request is made tocompanion.cal.comcompanion.cal.com?openExtension=trueauto-open flow to verify all open paths still workHuman Review Checklist
openSidebar()(icon click at L550,cal-companion-open-sidebarevent at L568, auto-open at L584)iframe.srcbefore it's set (the message listener guard at L93 is the only early-access point)