fix: default icon size to 16px in createIcon wrapper and fix download button alignment#27924
Merged
dhairyashiil merged 2 commits intomainfrom Feb 13, 2026
Merged
Conversation
…wnload alignment Co-Authored-By: eunjae@cal.com <hey@eunjae.dev>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: eunjae@cal.com <hey@eunjae.dev>
Contributor
There was a problem hiding this comment.
1 issue found across 2 files (changes from recent commits).
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="apps/web/modules/data-table/components/filters/AddFilterButton.tsx">
<violation number="1">
P2: Removing the explicit `size={16}` will revert the plus icon to its 24px default, making the add-filter button oversized again. Keep the size prop to preserve the intended 16px icon.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Contributor
Devin AI is addressing Cubic AI's review feedbackNew feedback has been sent to the existing Devin session. ✅ No changes pushed |
dhairyashiil
approved these changes
Feb 13, 2026
anikdhabal
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes two visual regressions on the Insights page:
@coss/ui/iconswrapped icons defaulting to wrong size: The icon migration in refactor: migrate Icon to component icons from @coss/ui/icons #27458 replaced<Icon name="plus" />(default 16px) with icons from@coss/ui/icons, which wrap lucide-react (default 24px). This caused icons like the "+" add-filter button to render 50% larger than intended. Fixed by settingsize = 16as the default in thecreateIconwrapper (packages/coss-ui/src/icons.tsx) so all ~155 wrapped icons match the old<Icon>component behavior. Callers that explicitly pass asizeprop are unaffected."Download" button vertically misaligned: The button had
self-end sm:self-baselineclasses that override the parent container'sitems-centeralignment. Fixed by removing the conflicting alignment classes.Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
/insights)DataTableFilters.FilterBar(Bookings, Members, etc.) — the "+" button should be correctly sizedHuman Review Checklist
size=16default doesn't shrink any icons that were relying on lucide's 24px default without passing an explicitsizepropLink to Devin run: https://app.devin.ai/sessions/c5eaaa3e63f042d6a2410c56957f64a6
Requested by: @eunjae-lee