fix(app-store): preserve existing enabled state during seed#27918
Merged
sahitya-chandra merged 2 commits intocalcom:mainfrom Feb 13, 2026
Merged
fix(app-store): preserve existing enabled state during seed#27918sahitya-chandra merged 2 commits intocalcom:mainfrom
sahitya-chandra merged 2 commits intocalcom:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="scripts/seed-app-store.ts">
<violation number="1" location="scripts/seed-app-store.ts:53">
P1: Default apps without API keys (apple-calendar, jitsi, caldav-calendar) will be disabled on fresh installations due to incorrect fallback logic</violation>
</file>
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Add one-off context when rerunning by tagging
@cubic-dev-aiwith guidance or docs links (includingllms.txt) - Ask questions if you need clarification on any suggestion
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
7e10835 to
956e37e
Compare
sahitya-chandra
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes an issue where apps (e.g. Google Calendar / Google Meet) were being unintentionally disabled during Docker restarts or database reseeding.
Problem
When
scripts/seed-app-store.tsruns, it recalculates theenabledflag for every app usingshouldEnableApp.On subsequent runs, if keys were
undefinedor validation logic behaved differently, the app'senabledfield could be set to false , even if it was previously configured and working correctly.The main issue I found is this loop in
scripts/seed-app-store.tsThis loop overrides the apps
enabledflag to befalseThis caused integrations to appear randomly disabled on self-hosted Docker instances after restart.
Solution
Preserve the existing enabled state if no new keys are provided.
What Was Tested
enabled = truein the database.enabledno longer flips tofalse.Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Reproduction (Before Fix)
Verification (After Fix)
Confirm:
enabledremainstrueEnvironment Variables
Ensure relevant integration credentials are set (e.g. Google OAuth keys) when testing validation logic.
Expected Behavior
enabledstate should only change when explicitly revalidated with new keys.