feat: Add optional team guest feature (#18947)#27811
feat: Add optional team guest feature (#18947)#27811Thisun-17 wants to merge 3 commits intocalcom:mainfrom
Conversation
|
|
There was a problem hiding this comment.
1 issue found across 14 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="apps/web/modules/event-types/components/tabs/advanced/EventAdvancedTab.tsx">
<violation number="1" location="apps/web/modules/event-types/components/tabs/advanced/EventAdvancedTab.tsx:1242">
P2: The toggle cannot be enabled because `isEnabled` depends on `value.length > 0`, but `onCheckedChange` does not update the value when turning on. The toggle reverts to off and the select never appears.</violation>
</file>
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Ask questions if you need clarification on any suggestion
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
apps/web/modules/event-types/components/tabs/advanced/EventAdvancedTab.tsx
Show resolved
Hide resolved
The onCheckedChange handler only handled the unchecked case, so toggling on was a no-op since isEnabled depends on a non-empty array. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Ryukemeister
left a comment
There was a problem hiding this comment.
hi @Thisun-17, thank you for your contribution. can you sign the contributor CLA and also add relevant tests for the new feature, thanks!
|
Implemented the optional team guest feature from #18947. Fixed the toggle bug found by @cubic-dev-ai. Ready for review! |
|
This PR has been marked as stale due to inactivity. If you're still working on it or need any help, please let us know or update the PR to keep it active. |
|
This PR is still active and ready for review. |
|
This PR has been marked as stale due to inactivity. If you're still working on it or need any help, please let us know or update the PR to keep it active. |
|
This PR is still active and ready for review. Happy to address any feedback! |
- Accept time and timeUnit params in Zapier addSubscription endpoint - Pass and persist time/timeUnit when creating webhook subscription - Schedule no-show tasks for existing future bookings on subscribe (mirrors the existing MEETING_ENDED/MEETING_STARTED pattern) Closes calcom#18992
Description
Implements the optional team guest feature requested in #18947.
Changes
optionalTeamGuestIdsfield to EventType schemaOPT-PARTICIPANTin calendar invitesUpgradeTeamsBadgefor non-team usersTesting
Fixes #18947