Skip to content

fix: remove duplicate translation keys in common.json#27769

Merged
romitg2 merged 1 commit intocalcom:mainfrom
AhmadYasser1:fix/remove-duplicate-translation-keys
Feb 9, 2026
Merged

fix: remove duplicate translation keys in common.json#27769
romitg2 merged 1 commit intocalcom:mainfrom
AhmadYasser1:fix/remove-duplicate-translation-keys

Conversation

@AhmadYasser1
Copy link
Copy Markdown
Contributor

Summary

  • Remove 4 duplicate keys from the English translations file (common.json)

Problem

The en/common.json file contains 4 keys that appear twice with different values, which causes the second occurrence to silently override the first when the JSON is parsed. This can lead to unexpected translation differences depending on key ordering.

Duplicate keys resolved

Key First value Second value Kept
routing_forms "Routing forms" "Routing forms" First (identical)
submit_feedback "Submit feedback" "Submit Feedback" "Submit feedback" (consistent casing)
skip_trial "Skip trial" "Skip trial period" "Skip trial" (used as button label)
availability_schedule "Availability Schedule" "Availability schedule" "Availability schedule" (sentence case)

Test plan

  • Verify routing forms label displays correctly
  • Verify submit feedback button text
  • Verify skip trial button in billing settings
  • Verify availability schedule label in event types

Fixes #23478

Remove 4 duplicate keys that existed in the English translations file:
- routing_forms: identical duplicate removed
- submit_feedback: kept "Submit feedback" (consistent casing)
- skip_trial: kept "Skip trial" (used as button label)
- availability_schedule: kept "Availability schedule" (sentence case),
  removed duplicate with inconsistent capitalization

Fixes calcom#23478
@github-actions github-actions bot added i18n area: i18n, translations Low priority Created by Linear-GitHub Sync 🐛 bug Something isn't working labels Feb 8, 2026
@AhmadYasser1 AhmadYasser1 marked this pull request as ready for review February 8, 2026 23:34
@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Feb 8, 2026
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@romitg2 romitg2 added the run-ci Approve CI to run for external contributors label Feb 9, 2026
@romitg2 romitg2 enabled auto-merge (squash) February 9, 2026 04:10
@romitg2 romitg2 merged commit e940aac into calcom:main Feb 9, 2026
96 of 107 checks passed
@romitg2
Copy link
Copy Markdown
Member

romitg2 commented Feb 9, 2026

Thanks @AhmadYasser1 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working community Created by Linear-GitHub Sync i18n area: i18n, translations Low priority Created by Linear-GitHub Sync ready-for-e2e run-ci Approve CI to run for external contributors size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicate values found in common.json keys

2 participants