feat: add ARIA labels to time format and layout toggle controls#27760
Merged
dhairyashiil merged 1 commit intocalcom:mainfrom Feb 9, 2026
Merged
Conversation
Add aria-label to the TimeFormatToggle and LayoutToggle components on the booking page so screen readers can identify these radio groups. Uses existing translation keys "time_format" and "layout". Fixes calcom#20703
dhairyashiil
approved these changes
Feb 9, 2026
Member
dhairyashiil
left a comment
There was a problem hiding this comment.
Thank you for the contribution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aria-labelto the time format toggle (TimeFormatToggle) and the layout toggle (LayoutToggle) on the booking pageChanges
packages/features/bookings/components/TimeFormatToggle.tsx: Addaria-label={t("time_format")}to the ToggleGrouppackages/features/bookings/components/Header.tsx: Addaria-label={t("layout")}to the layout ToggleGroupRoot Cause
The Radix UI ToggleGroup renders as a
radiogrouprole element, but without anaria-label, screen readers cannot convey the purpose of these controls. This violates WCAG 4.1.2 (Name, Role, Value).Fix
Pass
aria-labelusing existing translation keys ("time_format"→ "Time format","layout"→ "Layout") to the ToggleGroup components. The prop flows through to the Radix root element via the spread props.Test plan
aria-label="Time format"in the DOMaria-label="Layout"in the DOMFixes #20703