Merged
Conversation
joeauyeung
commented
Feb 5, 2026
Comment on lines
+160
to
+164
| for (const userId of allTeamMemberIds) { | ||
| const memberData: { | ||
| userId: UserId; | ||
| attributes: Record<AttributeId, AttributeOptionValueWithType>; | ||
| } = { userId, attributes: {} }; |
Contributor
Author
There was a problem hiding this comment.
This is the main fix. We were only evaluating members who had the attributes that are being evaluated assigned to them. Now this includes all members even if they don't have the attribute assigned to them.
| setAssignRRMembersUsingSegment={setAssignRRMembersUsingSegment} | ||
| rrSegmentQueryValue={rrSegmentQueryValue} | ||
| setRrSegmentQueryValue={setRrSegmentQueryValue} | ||
| filterMemberIds={value.filter((host) => !host.isFixed).map((host) => host.userId)} |
Member
There was a problem hiding this comment.
This looks unintentional. Could you confirm @joeauyeung
Contributor
Author
There was a problem hiding this comment.
This was because there's some odd UI case where the members that fit the attribute query don't render unless saved. I couldn't replicate again so I'll revert this change.
3 tasks
hariombalhara
requested changes
Feb 6, 2026
Member
hariombalhara
left a comment
There was a problem hiding this comment.
Except for https://github.com/calcom/cal.com/pull/27669/files#r2772201562
LGTM !!
Contributor
E2E results are ready! |
hariombalhara
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes exclusion attribute conditions. Ex. "Not any in". We now include all team members in the condition evaluation, not just members with the attribute we are evaluation.
Also adds tests to cover all attribute filters
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?