feat: show routing trace dialog on assignment reason badge click by joeauyeung · Pull Request #27629 · calcom/cal.com

joeauyeung · 2026-02-04T17:57:27Z

What does this PR do?

This PR adds the ability to view the routing trace dialog when clicking on the assignment reason badge in two places:

BookingListItem - When a booking has an assignment reason, clicking the badge now opens the RoutingTraceSheet to show the routing trace details
Booking Single View Page - Added a clickable assignment reason badge that opens the RoutingTraceSheet, only visible to users with permission to view hidden data (hosts and team members)

The existing RoutingTraceSheet component is reused in both locations.

Updates since last revision

Fixed duplicate RoutingTraceSheet rendering issue: The sheet was being rendered in both BookingListItem.tsx and BookingActionsDropdown.tsx, causing duplicate sheets and double data fetches when clicking the badge
Moved RoutingTraceSheet rendering to only BookingActionsDropdown.tsx with condition booking.assignmentReason.length > 0
Removed redundant RoutingTraceSheet from BookingListItem.tsx (the click handler still works via shared store state)

Mandatory Tasks (DO NOT REMOVE)

I have self-reviewed the code (A decent size PR without self-review might be rejected).
I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. N/A - no documentation changes needed.
I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

Create a booking that was routed through a routing form (so it has an assignment reason)
Navigate to the bookings list view
Click on the assignment reason badge on a booking item - the routing trace sheet should open
Verify only one sheet opens (not duplicates)
Navigate to the booking single view page (click on a booking to view details)
If you are the host or a team member, you should see the assignment reason section
Click on the assignment reason badge - the routing trace sheet should open

Permission check: The routing trace on the booking single view page should only be visible to users who have canViewHiddenData permission (hosts and team members).

Human Review Checklist

Verify clicking assignment reason badge in BookingListItem opens the RoutingTraceSheet correctly (via shared store state with BookingActionsDropdown)
Confirm no duplicate sheets appear when clicking the badge
Verify the condition booking.assignmentReason.length > 0 is appropriate for showing the routing trace

Checklist

My code follows the style guidelines of this project
I have checked if my changes generate no new warnings

Link to Devin run: https://app.devin.ai/sessions/a8b6f7773b174705b0e378f642de1e45
Requested by: @joeauyeung

Co-Authored-By: joe@cal.com <j.auyeung419@gmail.com>

devin-ai-integration · 2026-02-04T17:57:39Z

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

Address comments on this PR that start with 'DevinAI' or '@devin'.
Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

Disable automatic comment and CI monitoring

joeauyeung · 2026-02-04T18:49:43Z

apps/web/modules/bookings/views/bookings-single-view.tsx

                                    {bookingInfo.assignmentReason[0].reasonString}
                                  </p>
                                )}
+                                <RoutingTraceSheet


There's already a check in place to only show the assignment reason to people who have permission to view it.

cubic-dev-ai

1 issue found across 2 files

Prompt for AI agents (all issues)


Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="apps/web/components/booking/BookingListItem.tsx">

<violation number="1" location="apps/web/components/booking/BookingListItem.tsx:542">
P2: RoutingTraceSheet is now rendered twice for routing-form bookings (once here and once in BookingActionsDropdown), so clicking the badge will open duplicate sheets and double data fetches. Render only one instance per booking.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

apps/web/components/booking/BookingListItem.tsx

github-actions · 2026-02-04T18:57:50Z

Devin AI is addressing Cubic AI's review feedback

New feedback has been sent to the existing Devin session.

View Devin Session

✅ No changes pushed (confidence score 7/10 is below 9/10 threshold)

- Remove RoutingTraceSheet from BookingListItem.tsx to avoid duplicate rendering - Move RoutingTraceSheet in BookingActionsDropdown.tsx outside of isBookingFromRoutingForm condition - Use booking.assignmentReason.length > 0 condition for RoutingTraceSheet rendering - Remove unused isOpenRoutingTraceSheet getter and RoutingTraceSheet import from BookingListItem.tsx Co-Authored-By: joe@cal.com <j.auyeung419@gmail.com>

Udit-takkar · 2026-02-06T12:54:08Z

apps/web/components/booking/actions/BookingActionsDropdown.tsx

+          bookingUid={booking.uid}
+          routingReason={booking.assignmentReason[0]?.reasonString ?? null}
+          guestEmail={booking.attendees[0]?.email ?? ""}
+          hostEmail={booking.user?.email ?? ""}


Why are we just considering booking.user?.email as host? In a round robin event there could be some fixed hosts as well so more than one hosts are also possible

devin-ai-integration

Devin Review found 1 potential issue.

View 3 additional findings in Devin Review.

devin-ai-integration · 2026-02-09T09:03:59Z

apps/web/components/booking/actions/BookingActionsDropdown.tsx

🟡 Dropdown 'Routing Trace' menu item guarded by different condition than RoutingTraceSheet, causing no-op click

In BookingActionsDropdown.tsx, the "Routing Trace" dropdown menu item at line 678 is conditionally rendered using isBookingFromRoutingForm (which requires !!booking.routedFromRoutingFormReponse && !!booking.eventType?.team), but the RoutingTraceSheet component at line 469 is now rendered using booking.assignmentReason.length > 0. These are independent conditions that can diverge.

Root Cause

Before this PR, both the menu item and the RoutingTraceSheet were inside the same {isBookingFromRoutingForm && (...)} block, so they always appeared together. The PR moved RoutingTraceSheet out to use booking.assignmentReason.length > 0 as its guard (line 469), but left the dropdown menu item at line 678 using the old isBookingFromRoutingForm condition.

When isBookingFromRoutingForm is true but booking.assignmentReason is empty (e.g., a routing-form booking without a recorded assignment reason), the user sees the "Routing Trace" menu item in the dropdown and can click it (setIsOpenRoutingTraceSheet(true) fires at line 685), but no RoutingTraceSheet component is rendered to respond to that state change. The click does nothing.

Impact: Users see a clickable "Routing Trace" action that silently does nothing for routing-form bookings without assignment reasons.

(Refers to lines 678-691)

Was this helpful? React with 👍 or 👎 to provide feedback.

feat: show routing trace dialog on assignment reason badge click

07ed8ea

Co-Authored-By: joe@cal.com <j.auyeung419@gmail.com>

pull-request-size bot added the size/S label Feb 4, 2026

joeauyeung added the ready-for-e2e label Feb 4, 2026

joeauyeung commented Feb 4, 2026

View reviewed changes

joeauyeung marked this pull request as ready for review February 4, 2026 18:50

graphite-app bot requested a review from a team February 4, 2026 18:50

graphite-app bot added core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO labels Feb 4, 2026

cubic-dev-ai bot reviewed Feb 4, 2026

View reviewed changes

apps/web/components/booking/BookingListItem.tsx Outdated Show resolved Hide resolved

pull-request-size bot added size/M and removed size/S labels Feb 4, 2026

Udit-takkar reviewed Feb 6, 2026

View reviewed changes

devin-ai-integration bot reviewed Feb 9, 2026

View reviewed changes

hariombalhara approved these changes Feb 9, 2026

View reviewed changes

joeauyeung merged commit 82a4780 into main Feb 9, 2026
63 checks passed

joeauyeung deleted the devin/1770227277-routing-trace-dialog branch February 9, 2026 15:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: show routing trace dialog on assignment reason badge click#27629

feat: show routing trace dialog on assignment reason badge click#27629
joeauyeung merged 2 commits intomainfrom
devin/1770227277-routing-trace-dialog

joeauyeung commented Feb 4, 2026 •

edited by devin-ai-integration bot

Loading

Uh oh!

devin-ai-integration bot commented Feb 4, 2026

Uh oh!

joeauyeung Feb 4, 2026

Uh oh!

cubic-dev-ai bot left a comment

Uh oh!

Uh oh!

github-actions bot commented Feb 4, 2026 •

edited by devin-ai-integration bot

Loading

Uh oh!

Udit-takkar Feb 6, 2026

Uh oh!

devin-ai-integration bot left a comment

Uh oh!

devin-ai-integration bot Feb 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

joeauyeung commented Feb 4, 2026 • edited by devin-ai-integration bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Updates since last revision

Mandatory Tasks (DO NOT REMOVE)

How should this be tested?

Human Review Checklist

Checklist

Uh oh!

devin-ai-integration bot commented Feb 4, 2026

🤖 Devin AI Engineer

Uh oh!

joeauyeung Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Feb 4, 2026 • edited by devin-ai-integration bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Devin AI is addressing Cubic AI's review feedback

Uh oh!

Udit-takkar Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration bot Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

joeauyeung commented Feb 4, 2026 •

edited by devin-ai-integration bot

Loading

github-actions bot commented Feb 4, 2026 •

edited by devin-ai-integration bot

Loading