feat(companion): add configurable first page setting by dhairyashiil · Pull Request #27267 · calcom/cal.com

dhairyashiil · 2026-01-27T02:42:13Z

apps

Screen.Recording.2026-01-27.at.9.57.44.AM.mov

extension

Screen.Recording.2026-01-27.at.10.02.26.AM.mov

added success alert

Screen.Recording.2026-01-27.at.10.21.31.AM.mov

What does this PR do?

Adds a configurable landing page feature to the companion app, allowing users to choose which page the app opens to on launch. Users can select from Event Types, Bookings, or Bookings with a specific filter (Upcoming, Unconfirmed, Recurring, Past, Cancelled).

Changes:

New useUserPreferences hook for persistent storage of landing page preference using generalStorage
Tab index now redirects based on user preference instead of hardcoded event-types
Bookings pages accept initial filter from URL params
New "App Settings" section in More screen with landing page selector
Platform-specific LandingPagePicker components (Modal for Android/web, native ActionSheetIOS for iOS)
User preferences are cleared on logout for fresh state

Updates since last revision:

Fixed React Compiler compatibility by removing try-finally pattern in useUserPreferences hook (React Compiler doesn't support TryStatement with finalizer clause)

Link to Devin run: https://app.devin.ai/sessions/0d7cf7af9228410ba158026afd3e842d
Requested by: Dhairyashil Shinde (@dhairyashiil)

Mandatory Tasks (DO NOT REMOVE)

I have self-reviewed the code (A decent size PR without self-review might be rejected).
I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. N/A - no docs changes needed.
I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

Open the companion app and navigate to More > App Settings > Default Landing Page
Select different landing page options (Event Types, Bookings, Bookings with filters)
Close and reopen the app - verify it opens to the selected page
For bookings with filter options, verify the correct filter is pre-selected
Log out and log back in - verify preferences are reset to default (Event Types)

Test on both iOS and Android to verify platform-specific picker implementations work correctly.

Checklist

My code follows the style guidelines of this project
I have checked if my changes generate no new warnings

Items for Human Review

Verify the type cast (filter as BookingFilter) in bookings index files is safe - an invalid URL param could cause issues
Verify iOS ActionSheetIOS behavior is acceptable (doesn't show current selection indicator like Android/web modal does)
Test logout flow properly clears preferences
Verify UI appearance on both iOS and Android platforms
Consider whether automated tests should be added for the useUserPreferences hook

- Add useUserPreferences hook for persistent storage of landing page preference - Add LandingPagePicker component for both iOS and Android/web platforms - Update tabs index to redirect based on user preference - Update bookings index to accept initial filter from URL params - Add App Settings section in More screen with landing page selector - Clear user preferences on logout for fresh state

devin-ai-integration · 2026-01-27T02:42:15Z

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

Address comments on this PR that start with 'DevinAI' or '@devin'.
Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

Disable automatic comment and CI monitoring

Replace Redirect component with router.replace() to fix TypeScript strict typing issue with expo-router's Href type for dynamic routes.

Use switch statement with literal route strings instead of dynamic string variable to satisfy expo-router's strict Href type checking.

dhairyashiil · 2026-01-27T04:36:00Z

useUserPreferences is now influencing initial routing + landing behavior across platforms That makes it a dependency-heavy decision point

One risk I’m thinking about If this hook evolves again (new flags / conditions) it could quietly affect multiple entry paths without obvious PR level visibility

Not blocking i just curious Is this intended to be a long term routing authority or should it stay narrow

This hook is intended to stay narrow - it only handles user preferences like landing page selection. Routing logic in layout file only uses the landing page preference. If we add more routing-related logic in the future, we should evaluate whether it belongs here or in a dedicated routing hook

cubic-dev-ai

10 issues found across 11 files

Prompt for AI agents (all issues)


Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="companion/app/(tabs)/(bookings)/index.tsx">

<violation number="1" location="companion/app/(tabs)/(bookings)/index.tsx:19">
P2: Validate the `filter` URL param before casting; an invalid value can produce an unsupported `activeFilter` and a `-1` `activeIndex`, which may break the filter UI or selection logic.</violation>
</file>

<file name="companion/components/LandingPagePicker.ios.tsx">

<violation number="1" location="companion/components/LandingPagePicker.ios.tsx:29">
P2: Localize the ActionSheetIOS title/message with t() and add the corresponding translation keys instead of hardcoded strings.</violation>
</file>

<file name="companion/app/(tabs)/(more)/index.ios.tsx">

<violation number="1" location="companion/app/(tabs)/(more)/index.ios.tsx:38">
P3: Localize newly added UI/alert text with `t()` instead of hardcoded strings so the labels and error message are translated consistently.</violation>
</file>

<file name="companion/hooks/useUserPreferences.ts">

<violation number="1" location="companion/hooks/useUserPreferences.ts:22">
P2: User-facing labels are hardcoded instead of using `t()` for localization. Please move these labels to translation keys and call `t()` here (and in the fallback).</violation>

<violation number="2" location="companion/hooks/useUserPreferences.ts:24">
P2: `LANDING_PAGE_OPTIONS` omits the `bookings:upcoming` option even though the type and routing support it, so users can’t select it and labels will fall back incorrectly. Add the missing option.</violation>
</file>

<file name="companion/app/(tabs)/(more)/index.tsx">

<violation number="1" location="companion/app/(tabs)/(more)/index.tsx:134">
P3: Localize the new App Settings and Default Landing Page labels with `t()` and add translation keys, instead of hardcoding text.</violation>
</file>

<file name="companion/components/LandingPagePicker.tsx">

<violation number="1" location="companion/components/LandingPagePicker.tsx:33">
P2: Hardcoded UI text should be localized via `t()`; add a translation key for this heading instead of embedding the English string directly.</violation>

<violation number="2" location="companion/components/LandingPagePicker.tsx:35">
P2: Localize this explanatory text using `t()` and a translation key instead of a hardcoded English sentence.</violation>

<violation number="3" location="companion/components/LandingPagePicker.tsx:68">
P3: Use the existing localized "cancel" string via `t("cancel")` rather than hardcoding the button label.</violation>
</file>

<file name="companion/app/(tabs)/_layout.tsx">

<violation number="1" location="companion/app/(tabs)/_layout.tsx:79">
P2: Localize this tab label via the i18n system (use `t()` with the appropriate translation key) instead of hardcoding the English string.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

companion/app/(tabs)/(bookings)/index.tsx

companion/components/LandingPagePicker.ios.tsx

companion/hooks/useUserPreferences.ts

companion/components/LandingPagePicker.tsx

companion/app/(tabs)/_layout.tsx

companion/app/(tabs)/(more)/index.ios.tsx

companion/app/(tabs)/(more)/index.tsx

companion/components/LandingPagePicker.tsx

github-actions · 2026-01-27T04:42:02Z

Devin AI is addressing Cubic AI's review feedback

A Devin session has been created to address the issues identified by Cubic AI.

View Devin Session

cubic-dev-ai

2 issues found across 2 files (changes from recent commits).

Prompt for AI agents (all issues)


Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="companion/app/(tabs)/(more)/index.ios.tsx">

<violation number="1" location="companion/app/(tabs)/(more)/index.ios.tsx:37">
P2: Localize the new success alert text with `t()` instead of hardcoded strings to follow the project’s localization requirement.</violation>
</file>

<file name="companion/app/(tabs)/(more)/index.tsx">

<violation number="1" location="companion/app/(tabs)/(more)/index.tsx:31">
P3: Localize the new success alert text via `t()` instead of hardcoded English strings so the message is translatable.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

companion/app/(tabs)/(more)/index.ios.tsx

companion/app/(tabs)/(more)/index.tsx

github-actions · 2026-01-27T04:58:14Z

Devin AI is addressing Cubic AI's review feedback

New feedback has been sent to the existing Devin session.

View Devin Session

cubic-dev-ai

6 issues found across 4 files (changes from recent commits).

Prompt for AI agents (all issues)


Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="companion/components/LandingPagePicker.ios.tsx">

<violation number="1" location="companion/components/LandingPagePicker.ios.tsx:29">
P2: Localize this UI string with `t()` instead of hardcoding text so it follows the app’s i18n requirements.</violation>
</file>

<file name="companion/components/LandingPagePicker.tsx">

<violation number="1" location="companion/components/LandingPagePicker.tsx:33">
P3: Localize this new UI string with `t()` and a translation key instead of hard-coding text.</violation>
</file>

<file name="companion/app/(tabs)/(more)/index.ios.tsx">

<violation number="1" location="companion/app/(tabs)/(more)/index.ios.tsx:37">
P2: Localize the new success message with the i18n helper instead of a hardcoded string so it participates in translations.</violation>

<violation number="2" location="companion/app/(tabs)/(more)/index.ios.tsx:171">
P2: Localize this label with the i18n helper instead of hardcoding the text so it can be translated.</violation>
</file>

<file name="companion/app/(tabs)/(more)/index.tsx">

<violation number="1" location="companion/app/(tabs)/(more)/index.tsx:31">
P2: Localize this new success message with `t()` instead of a hardcoded string; add a translation key to the source locale so it can be managed by the i18n workflow.</violation>

<violation number="2" location="companion/app/(tabs)/(more)/index.tsx:143">
P2: Localize this new label with `t()` and add a translation key in the source locale instead of hardcoding the string.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

companion/components/LandingPagePicker.ios.tsx

companion/app/(tabs)/(more)/index.ios.tsx

companion/app/(tabs)/(more)/index.tsx

companion/components/LandingPagePicker.tsx

* remove bg color from empty screen * fix crash v1 * fix done for ios and android * fix lint

cubic-dev-ai

1 issue found across 4 files (changes from recent commits).

Prompt for AI agents (all issues)


Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="companion/app/(tabs)/(bookings)/index.tsx">

<violation number="1" location="companion/app/(tabs)/(bookings)/index.tsx:70">
P2: `lastUrlFilter` is never reset, so subsequent deep links to the same filter value are ignored even when the current filter differs. That prevents URL params from re-syncing the filter after a user changes it.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

companion/app/(tabs)/(bookings)/index.tsx

github-actions · 2026-02-07T17:33:05Z

Devin AI is addressing Cubic AI's review feedback

A Devin session has been created to address the issues identified by Cubic AI.

View Devin Session

…github.com/calcom/cal.com into devin/1769481332-configurable-landing-page

devin-ai-integration · 2026-02-07T17:35:44Z

Cubic AI Review - Confidence Score Assessment

I reviewed all Cubic AI comments on this PR to check their confidence scores ("confidence" in metadata). Per the task guidelines, only issues with confidence 9/10 or higher should be fixed.

Summary of all Cubic AI confidence scores found:

Score	Count	Examples
6/10	1	Cancel button localization (`LandingPagePicker.tsx:68`)
7/10	6	`lastUrlFilter` never reset (`bookings/index.tsx:70`), various localization issues
8/10	12	Missing `bookings:upcoming` option, localization of labels/alerts/tab strings

Result: No Cubic AI comment on this PR has a confidence score of 9/10 or higher. The highest confidence score across all 19 Cubic comments is 8/10.

The specific issue flagged for this session (lastUrlFilter is never reset at bookings/index.tsx:70) has a confidence score of 7/10, which is below the 9/10 threshold.

No code changes were made as none of the issues met the required confidence threshold.

Link to Devin run

dhairyashiil · 2026-02-07T18:44:07Z

android widget (pushed changes into this pr, i should have created a new pr, sorrry, from next time i will create new ones)

Screen.Recording.2026-02-08.at.12.00.16.AM.mov

pull-request-size bot added the size/L label Jan 27, 2026

dhairyashiil added 6 commits January 27, 2026 02:46

fix(companion): remove try-finally for React Compiler compatibility

832ae51

Merge branch 'main' into devin/1769481332-configurable-landing-page

669cbf7

fix(companion): use router.replace for dynamic landing page redirect

9ef07ef

Replace Redirect component with router.replace() to fix TypeScript strict typing issue with expo-router's Href type for dynamic routes.

fix(companion): use literal route strings for TypeScript strict typing

2ac6a5e

Use switch statement with literal route strings instead of dynamic string variable to satisfy expo-router's strict Href type checking.

working fix

0dc732b

better css

251f429

This comment was marked as spam.

Sign in to view

dhairyashiil marked this pull request as ready for review January 27, 2026 04:34

graphite-app bot added the core area: core, team members only label Jan 27, 2026

dhairyashiil enabled auto-merge (squash) January 27, 2026 04:36

cubic-dev-ai bot reviewed Jan 27, 2026

View reviewed changes

dhairyashiil added 3 commits January 27, 2026 10:15

fix lint

7f9f115

address cubics comments

41057ff

success alert

d12770b

cubic-dev-ai bot reviewed Jan 27, 2026

View reviewed changes

companion/app/(tabs)/(more)/index.ios.tsx Outdated Show resolved Hide resolved

companion/app/(tabs)/(more)/index.tsx Outdated Show resolved Hide resolved

This comment was marked as spam.

Sign in to view

change title to first page

3035f72

cubic-dev-ai bot reviewed Feb 7, 2026

View reviewed changes

dhairyashiil added 2 commits February 7, 2026 20:31

remove border from empty screen

daa06ac

resolve merge conflicts

82729b9

pull-request-size bot added size/XL and removed size/L labels Feb 7, 2026

dhairyashiil and others added 2 commits February 7, 2026 22:17

remove bg color from empty screen

e128f3b

fix(companion): booking list page crash and dropdown filter (#27733)

e54c3a1

* remove bg color from empty screen * fix crash v1 * fix done for ios and android * fix lint

cubic-dev-ai bot reviewed Feb 7, 2026

View reviewed changes

companion/app/(tabs)/(bookings)/index.tsx Show resolved Hide resolved

Merge branch 'devin/1769481332-configurable-landing-page' of https://…

cedb49f

…github.com/calcom/cal.com into devin/1769481332-configurable-landing-page

dhairyashiil and others added 2 commits February 8, 2026 00:01

android widget preview image

02e45f3

one click flow (#27736)

f5f7af1

update version to 1.0.4

5ffc141

dhairyashiil changed the title ~~feat(companion): add configurable landing page~~ feat(companion): add configurable first page Feb 13, 2026

dhairyashiil changed the title ~~feat(companion): add configurable first page~~ feat(companion): add configurable first page setting Feb 13, 2026

volnei approved these changes Feb 13, 2026

View reviewed changes

dhairyashiil merged commit fa53f54 into main Feb 13, 2026
44 of 45 checks passed

dhairyashiil deleted the devin/1769481332-configurable-landing-page branch February 13, 2026 14:28

dhairyashiil mentioned this pull request Feb 15, 2026

feat(companion): add configurable landing page calcom/companion#3

Merged

4 tasks

Conversation

dhairyashiil commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Changes:

Updates since last revision:

Mandatory Tasks (DO NOT REMOVE)

How should this be tested?

Checklist

Items for Human Review

Uh oh!

devin-ai-integration bot commented Jan 27, 2026

🤖 Devin AI Engineer

Uh oh!

This comment was marked as spam.

dhairyashiil commented Jan 27, 2026

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jan 27, 2026

Devin AI is addressing Cubic AI's review feedback

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jan 27, 2026

Devin AI is addressing Cubic AI's review feedback

Uh oh!

This comment was marked as spam.

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Feb 7, 2026

Devin AI is addressing Cubic AI's review feedback

Uh oh!

devin-ai-integration bot commented Feb 7, 2026

Cubic AI Review - Confidence Score Assessment

Uh oh!

dhairyashiil commented Feb 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dhairyashiil commented Jan 27, 2026 •

edited

Loading