Skip to content

Feat/zapier app#2623

Merged
kodiakhq[bot] merged 53 commits intocalcom:mainfrom
CarinaWolli:feat/zapier-app
May 3, 2022
Merged

Feat/zapier app#2623
kodiakhq[bot] merged 53 commits intocalcom:mainfrom
CarinaWolli:feat/zapier-app

Conversation

@CarinaWolli
Copy link
Copy Markdown
Member

What does this PR do?

Adds Zapier App to App Store

Demo
https://www.loom.com/share/1f7bc75564014e0fa3e4415b2d416d40

fixes #1543

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

Checklist

  • I haven't checked if my PR needs changes to the documentation
  • I haven't added tests that prove my fix is effective or that my feature works

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 26, 2022

Someone is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 26, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview May 3, 2022 at 11:16PM (UTC)
2 Ignored Deployments
Name Status Preview Updated
docs ⬜️ Ignored (Inspect) May 3, 2022 at 11:16PM (UTC)
swagger ⬜️ Ignored (Inspect) May 3, 2022 at 11:16PM (UTC)

@PeerRich
Copy link
Copy Markdown
Member

this is super dope! great setup screen (cc @Jaibles – we should use this for other apps too) and great loom! cant wait to have this go live.

do we also plan to have actions? or only triggers for now

@PeerRich
Copy link
Copy Markdown
Member

also added you to the calcom organisation so you can now create branches from within the repo vs from the outside fork

@PeerRich PeerRich requested review from emrysal and zomars April 26, 2022 20:30
Copy link
Copy Markdown
Contributor

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments and updates. Overall this is very well done. Just making some adjustments to match our new way to handle app installations.

api_key: process.env.GIPHY_API_KEY,
});
}
await createApp("zapier", "zapier", ["other"], "zapier_other");
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so the app is actually added to the DB

hashedKey String @unique()
user User? @relation(fields: [userId], references: [id], onDelete: Cascade)
hashedKey String @unique()
apiKeyType ApiKeyType @default(OTHER)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW we now have an App model. It theory we could just add a relationship like: appId: "zapier" that way we could have a way to fetch only zapier related api keys without having add a new type.

"generate_api_key": "Generate Api Key",
"your_unique_api_key": "Your unique API key",
"copy_safe_api_key": "Copy this API key and save it somewhere safe. If you lose this key you have to generate a new one.",
"zapier_setup_instructions": "<0>Log into your Zapier account and create a new Zap.</0><1>Select Cal.com as your Trigger app. Also choose a Trigger event.</1><2>Choose your account and then enter your Unique API Key.</2><3>Test your Trigger.</3><4>You're set!</4>",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consolidated setup instructions to a single string.

"example_name": "Juan Pérez",
"you_are_being_redirected": "Serás redirigido a {{ url }} en $t(second, {\"count\": {{seconds}} })."
"you_are_being_redirected": "Serás redirigido a {{ url }} en $t(second, {\"count\": {{seconds}} }).",
"zapier_setup_instructions": "<0>Inicia sesión en tu cuenta de Zapier y crea un nuevo Zap.</0><1>Selecciona Cal.com cómo tu aplicación disparadora. Tambien elige tu evento disparador.</1><2>Elige tu cuenta e ingresa tu Clave API única.</2><3>Prueba tu disparador.</3><4>¡Listo!</4>"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also added Spanish translation to make sure it works

@kodiakhq kodiakhq bot merged commit 02b935b into calcom:main May 3, 2022
@zomars zomars mentioned this pull request May 3, 2022
@zomars zomars added this to the v.1.6 milestone May 3, 2022
@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge ♻️ autoupdate tells kodiak to keep this branch up-to-date core area: core, team members only

Projects

No open projects

Development

Successfully merging this pull request may close these issues.

Zapier App

6 participants