Skip to content

fix: disable save button when workflow has no changes#25973

Merged
romitg2 merged 23 commits intocalcom:mainfrom
Anshumancanrock:fix-workflows-save-button
Feb 9, 2026
Merged

fix: disable save button when workflow has no changes#25973
romitg2 merged 23 commits intocalcom:mainfrom
Anshumancanrock:fix-workflows-save-button

Conversation

@Anshumancanrock
Copy link
Copy Markdown
Contributor

@Anshumancanrock Anshumancanrock commented Dec 17, 2025

What does this PR do?

This PR fixes a bug in the workflow editor where the Save button remains clickable even when no changes have been made to the form.

Visual Demo (For contributors especially)

  • Before:
Recording.2025-12-17.175843.1.mp4
  • After:
Recording.2025-12-17.184140.1.mp4

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  1. Make a change to the workflow
  2. Revert it back to the original value
  3. Expected: Save button becomes disabled again (form is no longer dirty)

@vercel
Copy link
Copy Markdown

vercel bot commented Dec 17, 2025

@Anshumancanrock is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Dec 17, 2025
@github-actions github-actions bot added the 🐛 bug Something isn't working label Dec 17, 2025
cubic-dev-ai[bot]
cubic-dev-ai bot reviewed Dec 17, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@Anshumancanrock
Copy link
Copy Markdown
Contributor Author

Anshumancanrock commented Dec 18, 2025

@dhairyashiil could you please review it ser ?

pallava-joshi
pallava-joshi reviewed Dec 19, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@pallava-joshi pallava-joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the standard way in other forms too? can you dig deeper into why it happened?

@Anshumancanrock
Copy link
Copy Markdown
Contributor Author

Anshumancanrock commented Dec 19, 2025

@pallava-joshi Yes ser, Same pattern is used in many other forms. For eg. General Settings page (general-view.tsx),team Profile, and Org Settings.

@Anshumancanrock
Copy link
Copy Markdown
Contributor Author

Anshumancanrock commented Dec 19, 2025 •
edited
Loading

@pallava-joshi The workflow form uses setValue()to load data, which React Hook Form treats as user changes, isDirty was true from the start. Other forms either use defaultValues or call reset() after loading to clear this. The workflow form was missing that reset() call.

dhairyashiil
dhairyashiil previously approved these changes Dec 19, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@dhairyashiil dhairyashiil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dhairyashiil dhairyashiil enabled auto-merge (squash) December 19, 2025 23:55
@github-actions github-actions bot added the Low priority Created by Linear-GitHub Sync label Dec 19, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 20, 2025 •
edited
Loading

E2E results are ready!

PeerRich
PeerRich previously approved these changes Dec 22, 2025
View reviewed changes
anikdhabal
anikdhabal previously requested changes Dec 22, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@anikdhabal anikdhabal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls fix the test

auto-merge was automatically disabled December 22, 2025 16:10

Head branch was pushed to by a user without write access

@Anshumancanrock Anshumancanrock force-pushed the fix-workflows-save-button branch from e49cc18 to 2eb1114 Compare December 22, 2025 16:10
@Anshumancanrock Anshumancanrock force-pushed the fix-workflows-save-button branch from 2eb1114 to c8d4c76 Compare December 22, 2025 16:19
@Anshumancanrock Anshumancanrock force-pushed the fix-workflows-save-button branch from d96a5fe to efe977a Compare December 22, 2025 19:04
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 16, 2026

Devin AI is resolving merge conflicts

This PR has merge conflicts with the main branch. A Devin session has been created to automatically resolve them.

View Devin Session

Devin will:

  1. Merge the latest main into this branch
  2. Resolve any conflicts intelligently
  3. Run lint/type checks to ensure validity
  4. Push the resolved changes

If you prefer to resolve conflicts manually, you can close the Devin session and handle it yourself.

@github-actions github-actions bot removed the Stale label Jan 17, 2026
@Ryukemeister Ryukemeister mentioned this pull request Jan 21, 2026
Closed
6 tasks
@romitg2 romitg2 added the run-ci Approve CI to run for external contributors label Feb 8, 2026
@romitg2 romitg2 self-assigned this Feb 8, 2026
@romitg2 romitg2 self-requested a review February 8, 2026 11:25
@romitg2 romitg2 dismissed stale reviews from dhairyashiil, pallava-joshi, and anikdhabal February 8, 2026 12:12

stale

@romitg2 romitg2 added run-ci Approve CI to run for external contributors and removed run-ci Approve CI to run for external contributors labels Feb 8, 2026
romitg2
romitg2 previously approved these changes Feb 8, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@romitg2 romitg2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@romitg2 romitg2 added run-ci Approve CI to run for external contributors and removed run-ci Approve CI to run for external contributors labels Feb 9, 2026
@romitg2 romitg2 enabled auto-merge (squash) February 9, 2026 08:55
@romitg2 romitg2 merged commit 9172fe6 into calcom:main Feb 9, 2026
107 of 118 checks passed
@romitg2
Copy link
Copy Markdown
Member

romitg2 commented Feb 9, 2026

Thanks @Anshumancanrock !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

@romitg2 romitg2 romitg2 approved these changes

@anikdhabal anikdhabal Awaiting requested review from anikdhabal

@dhairyashiil dhairyashiil Awaiting requested review from dhairyashiil

@pallava-joshi pallava-joshi Awaiting requested review from pallava-joshi

@PeerRich PeerRich Awaiting requested review from PeerRich

Assignees

@romitg2 romitg2

Labels

🐛 bug Something isn't working community Created by Linear-GitHub Sync Low priority Created by Linear-GitHub Sync ready-for-e2e run-ci Approve CI to run for external contributors size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The Save button in the workflow editor remains clickable even without changes

9 participants

@Anshumancanrock @pallava-joshi @romitg2 @PeerRich @anikdhabal @dhairyashiil @keithwillcode @calcom-bot @Ryukemeister