packages/app-store/_components/AppCard.tsx (1)

16-28: Prefer named export (repo guideline)

If this module doesn’t need a default export, prefer a named export for better tree-shaking and refactors.

-export default function AppCard({
+export function AppCard({

(Remember to update imports.)

packages/app-store/_components/EventTypeAppCardInterface.tsx (1)

29-31: Avoid hardcoded slug exceptions

Encode slug overrides in a map for scalability.

-          slug={app.slug === "stripe" ? "stripepayment" : app.slug}
+          slug={{ stripe: "stripepayment" }[app.slug] ?? app.slug}

packages/features/apps/components/AppList.tsx (2)

97-117: Shadowed identifier: locationType

Local const locationType shadows state variable locationType; rename to avoid confusion.

-                          const locationType = getLocationFromApp(item?.locationOption?.value ?? "");
-                          if (locationType?.linkType === "static") {
-                            setLocationType({ ...locationType, slug: appSlug });
+                          const locType = getLocationFromApp(item?.locationOption?.value ?? "");
+                          if (locType?.linkType === "static") {
+                            setLocationType({ ...locType, slug: appSlug });
                           } else {

---

176-177: Flatten nested arrays directly

Minor readability: Array of arrays can be rendered via .flat().

-        {cardsForAppsWithTeams.map((apps) => apps.map((cards) => cards))}
+        {cardsForAppsWithTeams.flat()}

packages/app-store/types.d.ts (2)

64-72: Prefer unknown over any for JSON blobs

Use unknown for safer typing; callers can narrow.

-  recurringEvent?: any; // Keep as any since this is JSON
+  recurringEvent?: unknown; // JSON blob

---

70-71: Consider narrowing schedulingType

If this maps to a known union (e.g., "round_robin" | "collective" | "one_on_one"), declare it to improve DX.

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Learnt from: supalarry
PR: calcom/cal.com#23217
File: apps/api/v2/src/ee/event-types/event-types_2024_06_14/services/output-event-types.service.ts:93-94
Timestamp: 2025-08-21T13:44:06.805Z
Learning: In apps/api/v2/src/ee/event-types/event-types_2024_06_14/event-types.repository.ts, repository functions that use explicit Prisma select clauses (like getEventTypeWithSeats) are used for specific purposes and don't need to include all EventType fields like bookingRequiresAuthentication. These methods don't feed into the general OutputEventTypesService_2024_06_14 flow.

packages/app-store/AppDependencyComponent.tsx (1)

13-16: Type says dependencyData is required but code guards for undefined. Pick one.

Either make dependencyData optional with a default value, or drop the null checks. Prefer defaulting to an empty array.

 export const AppDependencyComponent = ({
   appName,
-  dependencyData,
+  dependencyData = [],
 }: {
   appName: string;
-  dependencyData: { name: string; slug: string; installed: boolean }[];
+  dependencyData?: { name: string; slug: string; installed: boolean }[];
 }) => {

-        dependencyData && dependencyData.some((dependency) => !dependency.installed) ? "bg-info" : "bg-subtle"
+        dependencyData.some((dependency) => !dependency.installed) ? "bg-info" : "bg-subtle"
       )}>
-      {dependencyData &&
-        dependencyData.map((dependency) => {
+      {dependencyData.map((dependency) => {

Also applies to: 23-26

packages/app-store/_components/eventTypeAppCardInterface.test.tsx (2)

40-45: Loosen argument assertion for mocked component calls.

Passing a second argument {} is brittle and not required; assert only on the props object.

-    expect(DynamicComponent).toHaveBeenCalledWith(
-      expect.objectContaining({
-        slug: mockProps.app.slug,
-      }),
-      {}
-    );
+    expect(DynamicComponent).toHaveBeenCalledWith(
+      expect.objectContaining({ slug: mockProps.app.slug })
+    );

-    expect(DynamicComponent).toHaveBeenCalledWith(
-      expect.objectContaining({
-        slug: "stripepayment",
-      }),
-      {}
-    );
+    expect(DynamicComponent).toHaveBeenCalledWith(
+      expect.objectContaining({ slug: "stripepayment" })
+    );

Also applies to: 76-81

---

23-34: Prefer realistic fixture over empty object for credentialOwner.

If credentialOwner has a known shape, provide a minimal valid object to avoid masking type issues in tests.

packages/app-store/routing-forms/pages/route-builder/[...appPages].tsx (3)

109-112: Return a boolean from hasRules for clarity.

Current implementation returns number | undefined. Make it explicit boolean for readability and type-safety.

-const hasRules = (route: EditFormRoute) => {
-  if (isRouter(route)) return false;
-  route.queryValue.children1 && Object.keys(route.queryValue.children1).length;
-};
+const hasRules = (route: EditFormRoute) => {
+  if (isRouter(route)) return false;
+  const count = route.queryValue.children1
+    ? Object.keys(route.queryValue.children1).length
+    : 0;
+  return count > 0;
+};

---

86-107: Avoid any-cast in useEffect dependencies.

(route as unknown as any).action?.value defeats type-safety and can hide bugs. Prefer narrowing or deriving the value before the effect, then depend on it.

-  }, [eventOptions, setRoute, route.id, (route as unknown as any).action?.value]);
+  }, [eventOptions, setRoute, route.id, !isRouter(route) ? route.action.value : undefined]);

Alternatively, derive actionValue via a memo and reference that.

---

488-488: Localize all user-visible strings.

Several literals bypass t(), which breaks i18n consistency.

Suggested examples to wrap with t():

• label={route.name ?? t("route_n", { n: index + 1 })}
• "Conditions", "And connect with specific team members", "Fallback", "Send booker to"
• "We are not ready for you yet :(" (both occurrences)
• placeholders: "https://example.com", "event-url"
• EmptyState: header/text and the "Create your first route" copy

If you’d like, I can generate a diff adding t() keys.

Also applies to: 531-531, 581-581, 609-609, 798-798, 682-683, 817-818, 721-721, 857-857, 773-773, 909-909, 1324-1327, 1339-1340

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

packages/app-store/_utils/useIsAppEnabled.ts (3)

29-31: Use nullish coalescing to preserve 0 IDs and guard indexing.

Avoid treating 0 as falsy; also protect optional array access.

-    if (newValue && (app.userCredentialIds?.length || app.credentialOwner?.credentialId)) {
-      setAppData("credentialId", app.credentialOwner?.credentialId || app.userCredentialIds[0]);
+    if (
+      newValue &&
+      ((app.userCredentialIds?.length ?? 0) > 0 || app.credentialOwner?.credentialId != null)
+    ) {
+      setAppData("credentialId", app.credentialOwner?.credentialId ?? app.userCredentialIds?.[0]);
     }

---

7-7: Prefer named export over default (repo guideline).

Convert to a named export for better tree-shaking and refactors.

-function useIsAppEnabled(app: EventTypeAppCardApp) {
+export function useIsAppEnabled(app: EventTypeAppCardApp) {
@@
-export default useIsAppEnabled;
+// no default export

Also applies to: 38-38

---

5-5: Type upstream so the arrow param annotation isn’t needed.

If EventTypeAppCardApp.userCredentialIds is number[], TS infers id automatically; otherwise, keep the local check and make userCredentialIds optional-safe as suggested above.

Run to confirm the type shape and optionality:

#!/bin/bash
# Find the EventTypeAppCardApp definition and its userCredentialIds field
rg -nP -C3 --type=ts '(type|interface)\s+EventTypeAppCardApp\b'
rg -nP --type=ts -C2 '\buserCredentialIds\??:\s*number\[\]'
# Also check for alternative naming to ensure consistency
rg -nP --type=ts -C2 '\bcredentialIds\??:\s*number\[\]'

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.