packages/app-store/_utils/redirectApps.ts (2)

1-20: Centralize and optimize redirect app lookup (optional)

Current approach is fine for a small list. For readability/maintainability and O(1) lookup, consider freezing the list and using a Set.

Apply this diff:

-export const REDIRECT_APPS = [
+export const REDIRECT_APPS = [
   "amie",
   "autocheckin",
   "bolna",
   "chatbase",
   "clic",
   "deel",
   "elevenlabs",
   "granola",
   "greetmate-ai",
   "lindy",
   "linear",
   "millis-ai",
   "monobot",
   "retell-ai",
   "synthflow",
   "telli",
   "vimcal",
   "wordpress",
-];
+] as const;
+
+const REDIRECT_APPS_SET = new Set<string>(REDIRECT_APPS);
 
 export const isRedirectApp = (slug: string): boolean => {
-  return REDIRECT_APPS.includes(slug);
+  return REDIRECT_APPS_SET.has(slug);
 };

---

1-20: Consider documenting the source of truth

A brief comment on why these slugs are “redirect apps” and how they’re updated (code vs. config vs. backend) will help future contributors.

apps/web/components/apps/AppPage.tsx (1)

193-205: Consistent “Visit” UX with external-link icon

Rendering a dedicated Visit button with an external-link icon meets the “rename Install to Visit and make it an external link” requirement. Consider reusing InstallAppButtonChild (if feasible) for consistent styles/behavior with cards, but not strictly necessary.

packages/features/apps/components/AppCard.tsx (1)

204-221: Add a test id to the Visit button for E2E stability (optional)

Adding a data-testid helps keep UI tests robust when asserting redirect-app behavior.

Apply this diff:

   if (isRedirect) {
     return (
       <Button
         color="secondary"
         className="[@media(max-width:260px)]:w-full [@media(max-width:260px)]:justify-center"
         StartIcon="external-link"
+        data-testid="visit-app-button"
         {...props}
         size="base">
         {t("APPSTORE_VISIT")}
       </Button>
     );
   }

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Learnt from: Anshumancanrock
PR: calcom/cal.com#22570
File: apps/web/modules/signup-view.tsx:253-253
Timestamp: 2025-07-21T21:33:23.371Z
Learning: In signup-view.tsx, when checking if redirectUrl contains certain strings, using explicit && checks (redirectUrl && redirectUrl.includes()) is preferred over optional chaining (redirectUrl?.includes()) to ensure the result is always a boolean rather than potentially undefined. This approach provides cleaner boolean contracts for downstream conditional logic.

Learnt from: Anshumancanrock
PR: calcom/cal.com#22570
File: apps/web/modules/signup-view.tsx:253-253
Timestamp: 2025-07-21T21:33:23.371Z
Learning: In signup-view.tsx, when checking if redirectUrl contains certain strings, using explicit && checks (redirectUrl && redirectUrl.includes()) is preferred over optional chaining (redirectUrl?.includes()) to ensure the result is always a boolean rather than potentially undefined. This approach provides cleaner boolean contracts for downstream conditional logic.