fix(event-types): remove gap in URL input for event creation#22123
fix(event-types): remove gap in URL input for event creation#22123anikdhabal merged 8 commits intocalcom:mainfrom
Conversation
|
@ddoemonn is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
cubic reviewed 1 file and found no issues. Review PR in cubic.dev.
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (06/28/25)1 reviewer was added to this PR based on Keith Williams's automation. "Add community label" took an action on this PR • (06/28/25)1 label was added to this PR based on Keith Williams's automation. "Add ready-for-e2e label" took an action on this PR • (07/08/25)1 label was added to this PR based on Keith Williams's automation. |
…com into fix/event-type-url-spacing
There was a problem hiding this comment.
cubic found 3 issues across 2 files. Review them in cubic.dev
React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai to give specific feedback.
| ) : undefined | ||
| } | ||
| containerClassName="[&>div]:gap-0" | ||
| className="pl-0" |
There was a problem hiding this comment.
Setting className="pl-0" on the input may override existing padding styles, potentially affecting layout or accessibility. Ensure this does not conflict with other styles or reduce clickable area for users.
| </Tooltip> | ||
| ) : undefined | ||
| } | ||
| containerClassName="[&>div]:gap-0" |
There was a problem hiding this comment.
containerClassName is not a standard prop for most input components. If the underlying TextField component does not support this prop, it will be ignored and the intended style will not be applied.
| </Tooltip> | ||
| ) : undefined | ||
| } | ||
| containerClassName="[&>div]:gap-0" |
There was a problem hiding this comment.
The use of a Tailwind arbitrary selector ([&>div]:gap-0) may not be supported in all Tailwind configurations, especially if the JIT mode or safelisting is not enabled. This could lead to the style not being applied as intended in production builds.
|
@ddoemonn Pls address the cubic comments. |
E2E results are ready! |
|
This PR is being marked as stale due to inactivity. |
WalkthroughThe changes update the UI styling of the username and event slug input fields across three components. Specifically, a new container class Estimated code review effort1 (~2 minutes) Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
apps/web/components/ui/UsernameAvailability/UsernameTextfield.tsxOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-playwright". (The package "eslint-plugin-playwright" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: The plugin "eslint-plugin-playwright" was referenced from the config file in ".eslintrc.js". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. packages/features/eventtypes/components/tabs/setup/EventSetupTab.tsxOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-playwright". (The package "eslint-plugin-playwright" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: The plugin "eslint-plugin-playwright" was referenced from the config file in ".eslintrc.js". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. packages/features/eventtypes/components/CreateEventTypeForm.tsxOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-playwright". (The package "eslint-plugin-playwright" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: The plugin "eslint-plugin-playwright" was referenced from the config file in ".eslintrc.js". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
📓 Path-based instructions (1)**/*.{js,jsx,ts,tsx}📄 CodeRabbit Inference Engine (.cursor/rules/review.mdc)
Files:
🧠 Learnings (2)apps/web/components/ui/UsernameAvailability/UsernameTextfield.tsx (1)Learnt from: Anshumancanrock packages/features/eventtypes/components/CreateEventTypeForm.tsx (2)Learnt from: Anshumancanrock Learnt from: CR 🧰 Additional context used📓 Path-based instructions (1)**/*.{js,jsx,ts,tsx}📄 CodeRabbit Inference Engine (.cursor/rules/review.mdc)
Files:
🧠 Learnings (2)apps/web/components/ui/UsernameAvailability/UsernameTextfield.tsx (1)Learnt from: Anshumancanrock packages/features/eventtypes/components/CreateEventTypeForm.tsx (2)Learnt from: Anshumancanrock Learnt from: CR 🔇 Additional comments (1)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
What does this PR do?
Fixes the extra space appearing in generated event URL slugs when creating new event types. The issue was caused by CSS gap spacing between the URL prefix and input field, making URLs appear as
/username/ event-sluginstead of/username/event-slug.Image Demo (if applicable):
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
https://app.cal.com/event-types/username/demo-test-titlenot/username/ demo-test-titleChecklist
Summary by cubic
Fixed the extra space in the event URL input so the prefix and slug now appear seamlessly connected when creating a new event type.