Skip to content

fix: lock on user view#17077

Merged
anikdhabal merged 2 commits intocalcom:mainfrom
ezhil56x:lock
Oct 12, 2024
Merged

fix: lock on user view#17077
anikdhabal merged 2 commits intocalcom:mainfrom
ezhil56x:lock

Conversation

@ezhil56x
Copy link
Copy Markdown
Contributor

@ezhil56x ezhil56x commented Oct 12, 2024 •
edited
Loading

What does this PR do?

/claim #16021

Screenshot from 2024-10-12 17-16-50

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

@vercel
Copy link
Copy Markdown

vercel bot commented Oct 12, 2024

@ezhil56x is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Oct 12, 2024
@graphite-app graphite-app bot requested a review from a team October 12, 2024 11:51
@algora-pbc algora-pbc bot mentioned this pull request Oct 12, 2024
Closed
2 tasks
@github-actions github-actions bot added Low priority Created by Linear-GitHub Sync ui area: UI, frontend, button, form, input 🐛 bug Something isn't working 💎 Bounty A bounty on Algora.io labels Oct 12, 2024
@dosubot dosubot bot added the enterprise area: enterprise, audit log, organisation, SAML, SSO label Oct 12, 2024
@dosubot dosubot bot added this to the Community Only milestone Oct 12, 2024
@graphite-app
Copy link
Copy Markdown

graphite-app bot commented Oct 12, 2024 •
edited
Loading

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (10/12/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (10/12/24)

1 label was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (10/12/24)

1 label was added to this PR based on Keith Williams's automation.

anikdhabal
anikdhabal requested changes Oct 12, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@anikdhabal anikdhabal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ezhil56x thanks for your work. As you can see, on locked accounts, upon locking, the lock does not show up and needs a refresh. Fix it

@ezhil56x
Copy link
Copy Markdown
Contributor Author

ezhil56x commented Oct 12, 2024

@anikdhabal Fixed

@ezhil56x
Copy link
Copy Markdown
Contributor Author

ezhil56x commented Oct 12, 2024

2024-10-12.19-01-53.mp4

anikdhabal
anikdhabal approved these changes Oct 12, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@anikdhabal anikdhabal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anikdhabal anikdhabal enabled auto-merge (squash) October 12, 2024 13:36
@anikdhabal anikdhabal mentioned this pull request Oct 12, 2024
Closed
2 tasks
@anikdhabal anikdhabal merged commit 4a2c0cb into calcom:main Oct 12, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 12, 2024

E2E results are ready!

@ezhil56x ezhil56x deleted the lock branch February 7, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anikdhabal anikdhabal anikdhabal approved these changes

Assignees

No one assigned

Labels

🙋 Bounty claim 💎 Bounty A bounty on Algora.io 🐛 bug Something isn't working community Created by Linear-GitHub Sync enterprise area: enterprise, audit log, organisation, SAML, SSO Low priority Created by Linear-GitHub Sync ready-for-e2e ui area: UI, frontend, button, form, input

Projects

None yet

Milestone

Community Only

Development

Successfully merging this pull request may close these issues.

[CAL-4508] Visual issue on Users view, settings/admin/users

2 participants

@ezhil56x @anikdhabal