Skip to content

feat: added ability to assign event to all members#13219

Merged
PeerRich merged 24 commits intocalcom:mainfrom
Pradumn27:main
Jan 26, 2024
Merged

feat: added ability to assign event to all members#13219
PeerRich merged 24 commits intocalcom:mainfrom
Pradumn27:main

Conversation

@Pradumn27
Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes #10991

/claim #10991

Have added the ability to assign all team members a managed event type.

Requirement/Documentation

  • If there is a requirement document, please, share it here.
  • If there is ab UI/UX design document, please, share it here.
    Design Provided :
    265071602-ae6857af-f638-4331-8c3d-eee82807f7c1

Type of change

  • New feature (non-breaking change which adds functionality)

How should this be tested?

  • Create a team
  • Created a managed event with this team
  • Now got to settings -> assignment for this event type
  • Inside Assignment check the box above assign to drop down
  • See that all the members of the team get assigned to this event type (can check this from the db directly or by logging in ti the team member accounts individually)
  • Also test by inviting a new member to the team that they also get this event type assigned as the checkbox mentioned that the event type will be assigned to everyone in the team whenever added.

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't checked if my PR needs changes to the documentation
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@vercel
Copy link
Copy Markdown

vercel bot commented Jan 14, 2024

@Pradumn27 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 14, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@github-actions github-actions bot added ❗️ migrations contains migration files Medium priority Created by Linear-GitHub Sync teams area: teams, round robin, collective, managed event-types ✨ feature New feature or request 💎 Bounty A bounty on Algora.io labels Jan 14, 2024
@keithwillcode keithwillcode added the community Created by Linear-GitHub Sync label Jan 15, 2024
@CarinaWolli CarinaWolli requested a review from a team January 15, 2024 18:17
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 18, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@PeerRich PeerRich requested a review from Udit-takkar January 18, 2024 18:55
@PeerRich
Copy link
Copy Markdown
Member

@Pradumn27 does this also work with round robin and collective?

if not, can you make it work for all team events? round robin, collective, managed events

@Pradumn27
Copy link
Copy Markdown
Contributor Author

@Pradumn27 does this also work with round robin and collective?

if not, can you make it work for all team events? round robin, collective, managed events

@PeerRich yes have added an update to incorporate also for round robin and collective events can be tested in the similar manner as above

Screenshot 2024-01-19 at 1 54 38 AM Screenshot 2024-01-19 at 1 54 29 AM

Copy link
Copy Markdown
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pradumn27 I created a collective team event type and invited one more member to the team

Screenshot 2024-01-19 at 6 46 53 PM

I don't see the new user (teampro2@example.com) on the booking page

Screenshot 2024-01-19 at 6 48 14 PM

@Udit-takkar
Copy link
Copy Markdown
Contributor

Screenshot 2024-01-19 at 6 50 32 PM

I had to turn off the switch and then turn on again to assign all the members

Copy link
Copy Markdown
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another thing i don't think we should use this toggle for round robin event types because round robin assignment has two types 'Fixed hosts' and 'Round Robin Hosts'

cc: @PeerRich

Screenshot 2024-01-19 at 6 52 10 PM

@keithwillcode keithwillcode added this to the v3.8 milestone Jan 20, 2024
@Pradumn27
Copy link
Copy Markdown
Contributor Author

@Udit-takkar have resolved the issue, it was due to an error in the update team events query i wrote, but everything should be working fine now.

@Pradumn27
Copy link
Copy Markdown
Contributor Author

@CarinaWolli have resolved the above issues

@Pradumn27 Pradumn27 requested a review from CarinaWolli January 24, 2024 04:56
@PeerRich PeerRich dismissed stale reviews from CarinaWolli and Udit-takkar January 24, 2024 11:07

review again

Copy link
Copy Markdown
Member

@CarinaWolli CarinaWolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found another issue:

  1. Enable switch for collective event types, save
  2. Change scheduling type to round-robin, switch is and stays enabled, save
  3. Result: Round-robin has no hosts

@Pradumn27
Copy link
Copy Markdown
Contributor Author

Found another issue:

1. Enable switch for collective event types, save

2. Change scheduling type to round-robin, switch is and stays enabled, save

3. Result: Round-robin has no hosts

That's a nice catch, have resolved it now. @CarinaWolli

CarinaWolli
CarinaWolli previously approved these changes Jan 25, 2024
Copy link
Copy Markdown
Member

@CarinaWolli CarinaWolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great now 🙌🏻

@CarinaWolli CarinaWolli enabled auto-merge (squash) January 25, 2024 15:01
auto-merge was automatically disabled January 26, 2024 04:40

Head branch was pushed to by a user without write access

CarinaWolli
CarinaWolli previously approved these changes Jan 26, 2024
@PeerRich PeerRich enabled auto-merge (squash) January 26, 2024 16:22
Copy link
Copy Markdown
Member

@PeerRich PeerRich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job! I wonder if we wanna do something in a v2 of this where you can

  • ✅ Everyone
  • Exclude: Anna, Brian, etc.

@PeerRich PeerRich merged commit f9359aa into calcom:main Jan 26, 2024
@Pradumn27
Copy link
Copy Markdown
Contributor Author

nice job! I wonder if we wanna do something in a v2 of this where you can

  • ✅ Everyone
  • Exclude: Anna, Brian, etc.

Sounds like a good idea, can be usefull for users, a few questions though:

  1. Will we only show exclude members option when assignAllTeamMembers is selected or instead it's an alternative option which implies that everyone else apart from the specified people will be assigned and on selecting someone in this assignment option all other assignment options will be hidden(eg: if someone is selected to be excluded in assignment, other options like select hosts or assignAllTeamMembers will get hidden).

cc: @PeerRich

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🙋 Bounty claim 💎 Bounty A bounty on Algora.io community Created by Linear-GitHub Sync ✨ feature New feature or request Medium priority Created by Linear-GitHub Sync ❗️ migrations contains migration files teams area: teams, round robin, collective, managed event-types

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CAL-2611] team events: automatically add this to all members

5 participants