Fix timezones being returned from office 365#1269
Merged
PeerRich merged 2 commits intocalcom:mainfrom Dec 10, 2021
Merged
Conversation
Per the [api documentation](https://docs.microsoft.com/en-us/graph/api/calendar-list-calendarview?view=graph-rest-1.0&tabs=javascript#query-parameters) the `Prefer: outlook.timezone` is ignored if a timezone value is passed in the request. This forces the dates to be passed in UTC.
|
@sec0ndhand is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
Member
|
we need to test this locally or on staging 🙏 |
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/cal/calendso/GCAwrCmNxGMmo6A1d5BUKgQTRtKs |
PeerRich
approved these changes
Dec 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The problem
When scheduling on cal.com my calendar is not preventing times from being scheduled.
Reproducible Proof
If you visit this event You can watch the network requests come back with GMT and no times filtered. If you load the times as if in UTC it filters the dates(but you have to click on the 16th).
Solution
Per the microsoft graph api documentation
the
Prefer: outlook.timezoneis ignored if a timezone value is passedin the request. This forces the dates to be passed in UTC.
I don't know if there is a formal issue filed already, I talked to Conner in the support chat this morning and haven't heard back, so this is my attempt to fix it.
Type of change
How should this be tested?
Checklist: