Skip to content

chore: add Wizard in storybook (CALCOM-10760)#11166

Merged
PeerRich merged 2 commits intomainfrom
wizard-storybook
Sep 6, 2023
Merged

chore: add Wizard in storybook (CALCOM-10760)#11166
PeerRich merged 2 commits intomainfrom
wizard-storybook

Conversation

@gitstart-calcom
Copy link
Copy Markdown
Contributor

@gitstart-calcom gitstart-calcom commented Sep 6, 2023

Here is the GitStart Ticket for this pull request: CALCOM-10760

  • Please mark your PR as "ready for review" when you have completed all requirements.
  • Please ensure that your PR is reviewed by at least 2 people after you have completed it.
  • Comments for review or requested changes from the upstream client will be notified to you by email and will also show on the ticket page.
  • After the PR is merged on the upstream, please merge this PR.
  • If there exist merge conflicts on your current PR and you have to close the PR instead of merging it, please go to the ticket page to manually finish the task that is related to this PR.

Happy hacking! 🎉

DEMO

https://www.loom.com/share/29c39c63054b40be880f1ea34ce35ff9?sid=71d9de65-b996-4649-b245-136d8dc7b7bd

We added an explanation about why we can't use the next button to go to another step:

image

We already have a storybook file for steps component so we can test it there

@vercel
Copy link
Copy Markdown

vercel bot commented Sep 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ❌ Failed (Inspect) Sep 6, 2023 11:47am
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2023 11:47am
cal-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2023 11:47am
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2023 11:47am
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2023 11:47am
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Sep 6, 2023 11:47am
qa ⬜️ Ignored (Inspect) Visit Preview Sep 6, 2023 11:47am

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 6, 2023

Thank you for following the naming conventions! 🙏

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 6, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@deploysentinel
Copy link
Copy Markdown

deploysentinel bot commented Sep 6, 2023

Current Playwright Test Results Summary

✅ 117 Passing - ⚠️ 2 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 09/06/2023 11:49:23am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 6d09157

Started: 09/06/2023 11:45:59am UTC

⚠️ Flakes

📄   apps/web/playwright/login.2fa.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
2FA Tests should allow a user to enable 2FA and login using 2FA
Retry 2Retry 1Initial Attempt
0.70% (2) 2 / 285 runs
failed over last 7 days
27.37% (78) 78 / 285 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should be able to reschedule
Retry 1Initial Attempt
0.68% (2) 2 / 295 runs
failed over last 7 days
97.97% (289) 289 / 295 runs
flaked over last 7 days

View Detailed Build Results


@PeerRich PeerRich merged commit 9d6148d into main Sep 6, 2023
@PeerRich PeerRich deleted the wizard-storybook branch September 6, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants