Skip to content

chore: add Dropdown in storybook#10874

Merged
PeerRich merged 7 commits intomainfrom
dropdown-storybook
Sep 1, 2023
Merged

chore: add Dropdown in storybook#10874
PeerRich merged 7 commits intomainfrom
dropdown-storybook

Conversation

@gitstart-calcom
Copy link
Copy Markdown
Contributor

@gitstart-calcom gitstart-calcom commented Aug 21, 2023 •
edited
Loading

@vercel
Copy link
Copy Markdown

vercel bot commented Aug 21, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ❌ Failed (Inspect) Sep 1, 2023 3:32pm
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 1, 2023 3:32pm
cal-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 1, 2023 3:32pm
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 1, 2023 3:32pm
qa 🔄 Building (Inspect) Visit Preview 💬 Add feedback Sep 1, 2023 3:32pm
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 1, 2023 3:32pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Sep 1, 2023 3:32pm

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 21, 2023 •
edited
Loading

Thank you for following the naming conventions! 🙏

@zomars zomars added the core area: core, team members only label Aug 21, 2023
@gitstart-calcom gitstart-calcom marked this pull request as ready for review August 21, 2023 23:45
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 21, 2023 •
edited
Loading

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@deploysentinel
Copy link
Copy Markdown

deploysentinel bot commented Aug 21, 2023 •
edited
Loading

Current Playwright Test Results Summary

✅ 122 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 09/01/2023 03:35:21pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 4653a22

Started: 09/01/2023 03:33:39pm UTC

⚠️ Flakes

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt
5.92% (17) 17 / 287 runs
failed over last 7 days
93.73% (269) 269 / 287 runs
flaked over last 7 days

View Detailed Build Results

@gitstart-calcom gitstart-calcom marked this pull request as draft August 22, 2023 03:56
@gitstart-calcom gitstart-calcom marked this pull request as ready for review August 22, 2023 04:12
Udit-takkar
Udit-takkar previously requested changes Aug 23, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@Udit-takkar Udit-takkar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gitstart-calcom this is not how we implement and use dropdown.

you can check here

Screenshot 2023-08-23 at 1 39 31 PM

cal.com/apps/web/components/eventtype/EventTypeSingleLayout.tsx

Line 337 in 376f023

<Dropdown>

@sean-brydon
Copy link
Copy Markdown
Member

sean-brydon commented Aug 23, 2023

@gitstart-calcom this is not how we implement and use dropdown.

you can check here

Screenshot 2023-08-23 at 1 39 31 PM https://github.com/calcom/cal.com/blob/376f023e0fd69c0f30569152785b56c277a32bc8/apps/web/components/eventtype/EventTypeSingleLayout.tsx#L337

Damn we really need to cleanup these old components :D

@keithwillcode keithwillcode added the Low priority Created by Linear-GitHub Sync label Aug 23, 2023
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Aug 28, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@gitstart-calcom
Copy link
Copy Markdown
Contributor Author

gitstart-calcom commented Aug 29, 2023

Hi @Udit-takkar we made the requested changes here please take a look 😄

@gitstart-calcom gitstart-calcom changed the title chore: add Dropdown in storybook (CALCOM-10760) chore: add Dropdown in storybook Aug 30, 2023
@gitstart-calcom gitstart-calcom mentioned this pull request Aug 30, 2023
Closed
19 tasks
Udit-takkar
Udit-takkar reviewed Sep 1, 2023
View reviewed changes
packages/ui/components/form/dropdown/dropdown.stories.mdx
Comment on lines +48 to +52
#### DropdownMenuItem

<CustomArgsTable of={DropdownMenuItem} />

#### DropdownMenuSeparator
Copy link
Copy Markdown
Contributor

@Udit-takkar Udit-takkar Sep 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also mention DropdownItem here

Udit-takkar
Udit-takkar reviewed Sep 1, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left one comment

@gitstart-calcom
Copy link
Copy Markdown
Contributor Author

gitstart-calcom commented Sep 1, 2023

@Udit-takkar We made the changes here please take a look 😄

@PeerRich PeerRich merged commit 7d8559b into main Sep 1, 2023
@PeerRich PeerRich deleted the dropdown-storybook branch September 1, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Udit-takkar Udit-takkar Udit-takkar left review comments

@PeerRich PeerRich PeerRich approved these changes

@keithwillcode keithwillcode Awaiting requested review from keithwillcode

@shivamklr shivamklr Awaiting requested review from shivamklr

@sean-brydon sean-brydon Awaiting requested review from sean-brydon

Assignees

No one assigned

Labels

core area: core, team members only Low priority Created by Linear-GitHub Sync

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@gitstart-calcom @sean-brydon @CLAassistant @PeerRich @Udit-takkar @keithwillcode @zomars @gitstart