chore: add Navigation in storybook (CALCOM-10760)#10867
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
Contributor
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes! |
Contributor
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 146 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 10/09/2023 08:45:05am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: cd38c90 Started: 10/09/2023 08:40:49am UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
2FA Tests should allow a user to enable 2FA and login using 2FA
Retry 2 • Retry 1 • Initial Attempt |
0.90% (2)2 / 222 runsfailed over last 7 days |
37.84% (84)84 / 222 runsflaked over last 7 days |
📄 apps/web/playwright/booking-seats.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Reschedule for booking with seats Should reschedule booking with seats
Retry 1 • Initial Attempt |
0% (0)0 / 221 runsfailed over last 7 days |
0.90% (2)2 / 221 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt |
4.24% (10)10 / 236 runsfailed over last 7 days |
8.05% (19)19 / 236 runsflaked over last 7 days |
|
Popup Tests should be able to reschedule
Retry 2 • Retry 1 • Initial Attempt |
4.24% (10)10 / 236 runsfailed over last 7 days |
93.64% (221)221 / 236 runsflaked over last 7 days |
📄 apps/web/playwright/booking-pages.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
pro user can book an event that requires confirmation and then that booking can be accepted by organizer
Retry 1 • Initial Attempt |
6.87% (16)16 / 233 runsfailed over last 7 days |
0.86% (2)2 / 233 runsflaked over last 7 days |
📄 apps/web/playwright/teams.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Teams Can create a private team
Retry 1 • Initial Attempt |
0% (0)0 / 235 runsfailed over last 7 days |
25.11% (59)59 / 235 runsflaked over last 7 days |
📄 apps/web/playwright/managed-event-types.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Managed Event Types tests Can create managed event type
Retry 1 • Initial Attempt |
2.10% (5)5 / 238 runsfailed over last 7 days |
25.63% (61)61 / 238 runsflaked over last 7 days |
19 tasks
|
|
keithwillcode
previously requested changes
Oct 5, 2023
Contributor
keithwillcode
left a comment
There was a problem hiding this comment.
Seeing this. Know why, @gitstart-calcom?
Contributor
Author
|
@keithwillcode That's weird, we will look into that and provide a fix now |
Contributor
Author
|
@keithwillcode We noticed this is happening in all files, can we create a ticket to fix that? |
rereview please
PeerRich
approved these changes
Oct 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Demo
https://www.loom.com/share/7ce9b388d5af471180f2a3f409997614