Skip to content

chore: add ImageUploader in storybook (CALCOM-10760)#10865

Merged
keithwillcode merged 9 commits intomainfrom
image-uploader-storybook
Aug 25, 2023
Merged

chore: add ImageUploader in storybook (CALCOM-10760)#10865
keithwillcode merged 9 commits intomainfrom
image-uploader-storybook

Conversation

@gitstart-calcom
Copy link
Copy Markdown
Contributor

@gitstart-calcom gitstart-calcom commented Aug 21, 2023 •
edited
Loading

DEMO

262821190-9f738d60-abb2-498d-b3ec-9a2fd1598233.mov

@vercel
Copy link
Copy Markdown

vercel bot commented Aug 21, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ❌ Failed (Inspect) Aug 25, 2023 11:37am
cal-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 25, 2023 11:37am
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 25, 2023 11:37am
ui ❌ Failed (Inspect) Aug 25, 2023 11:37am
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Aug 25, 2023 11:37am
qa ⬜️ Ignored (Inspect) Visit Preview Aug 25, 2023 11:37am

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 21, 2023 •
edited
Loading

Thank you for following the naming conventions! 🙏

@zomars zomars added the core area: core, team members only label Aug 21, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 21, 2023 •
edited
Loading

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@deploysentinel
Copy link
Copy Markdown

deploysentinel bot commented Aug 21, 2023 •
edited
Loading

Current Playwright Test Results Summary

✅ 122 Passing - ⚠️ 3 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/25/2023 11:38:43am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 148e8b6

Started: 08/25/2023 11:36:50am UTC

⚠️ Flakes

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt
0.76% (2) 2 / 262 runs
failed over last 7 days
98.85% (259) 259 / 262 runs
flaked over last 7 days
📄   apps/web/playwright/event-types.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

 2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests user can add multiple organizer address
Retry 1 • Initial Attempt
0% (0) 0 / 251 runs
failed over last 7 days
2.79% (7) 7 / 251 runs
flaked over last 7 days
Event Types tests user Different Locations Tests can add Attendee Phone Number location and book with it
Retry 1 • Initial Attempt
0% (0) 0 / 24 runs
failed over last 7 days
4.17% (1) 1 / 24 run
flaked over last 7 days

View Detailed Build Results

@gitstart-calcom gitstart-calcom marked this pull request as ready for review August 21, 2023 18:23
@gitstart-calcom gitstart-calcom mentioned this pull request Aug 21, 2023
Closed
19 tasks
Udit-takkar
Udit-takkar reviewed Aug 23, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should open dark mode modal

Screenshot 2023-08-23 at 12 51 05 PM

like this

Screenshot 2023-08-23 at 12 51 45 PM

@keithwillcode keithwillcode added the Low priority Created by Linear-GitHub Sync label Aug 23, 2023
@gitstart-calcom
Copy link
Copy Markdown
Contributor Author

gitstart-calcom commented Aug 24, 2023

Hi @Udit-takkar, the requested changes have been made. Please take a look

@Udit-takkar
Copy link
Copy Markdown
Contributor

Udit-takkar commented Aug 24, 2023

@gitstart-calcom ui build (storybook) is failing

@gitstart-calcom
Copy link
Copy Markdown
Contributor Author

gitstart-calcom commented Aug 24, 2023

@gitstart-calcom ui build (storybook) is failing

Hi @Udit-takkar, it's failing on the main branch too due to the following code
Screenshot 2023-08-24 at 3 00 20 PM

@Udit-takkar Udit-takkar mentioned this pull request Aug 24, 2023
Merged
2 tasks
Udit-takkar
Udit-takkar approved these changes Aug 25, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

we are looking into fixing the build error

@keithwillcode keithwillcode merged commit 9904412 into main Aug 25, 2023
@keithwillcode keithwillcode deleted the image-uploader-storybook branch August 25, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Udit-takkar Udit-takkar Udit-takkar approved these changes

@keithwillcode keithwillcode Awaiting requested review from keithwillcode

@shivamklr shivamklr Awaiting requested review from shivamklr

@sean-brydon sean-brydon Awaiting requested review from sean-brydon

Assignees

No one assigned

Labels

core area: core, team members only Low priority Created by Linear-GitHub Sync

Projects

No open projects
Reviewing PRs
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gitstart-calcom @Udit-takkar @keithwillcode @zomars @gitstart