Skip to content

chore: add UnpublishedEntity in storybook (CALCOM-10760)#10864

Merged
keithwillcode merged 4 commits intomainfrom
UnpublishedEntity-storybook
Aug 25, 2023
Merged

chore: add UnpublishedEntity in storybook (CALCOM-10760)#10864
keithwillcode merged 4 commits intomainfrom
UnpublishedEntity-storybook

Conversation

@gitstart-calcom
Copy link
Copy Markdown
Contributor

@gitstart-calcom gitstart-calcom commented Aug 21, 2023

@vercel
Copy link
Copy Markdown

vercel bot commented Aug 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 25, 2023 8:42am
cal-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 25, 2023 8:42am
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 25, 2023 8:42am
ui ❌ Failed (Inspect) Aug 25, 2023 8:42am
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Aug 25, 2023 8:42am
qa ⬜️ Ignored (Inspect) Visit Preview Aug 25, 2023 8:42am

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 21, 2023

Thank you for following the naming conventions! 🙏

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 21, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@deploysentinel
Copy link
Copy Markdown

deploysentinel bot commented Aug 21, 2023

Current Playwright Test Results Summary

✅ 121 Passing - ⚠️ 3 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/25/2023 08:45:36am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 9558c4c

Started: 08/25/2023 08:43:12am UTC

⚠️ Flakes

📄   apps/web/playwright/login.2fa.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
2FA Tests should allow a user to enable 2FA and login using 2FA
Retry 1Initial Attempt
1.59% (4) 4 / 252 runs
failed over last 7 days
29.76% (75) 75 / 252 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should be able to reschedule
Retry 1Initial Attempt
0.78% (2) 2 / 256 runs
failed over last 7 days
98.83% (253) 253 / 256 runs
flaked over last 7 days

📄   packages/app-store/typeform/playwright/tests/basic.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Routing Forms Seeded Routing Form Routing Link should validate fields
Retry 1Initial Attempt
0.78% (2) 2 / 258 runs
failed over last 7 days
4.26% (11) 11 / 258 runs
flaked over last 7 days

View Detailed Build Results


Copy link
Copy Markdown
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gitstart-calcom can we use this addon https://storybook.js.org/addons/storybook-i18next to see the translated text instead of keys "team_is_unpublished"

@keithwillcode keithwillcode added the Low priority Created by Linear-GitHub Sync label Aug 23, 2023
@gitstart-calcom
Copy link
Copy Markdown
Contributor Author

gitstart-calcom commented Aug 25, 2023

Hi @Udit-takkar, we have added the support for translation. Please take a look

https://www.loom.com/share/fbdbea3c65dd4c808b03c839a8734c8a

import { initReactI18next } from "react-i18next";

const ns = ["common"];
const supportedLngs = ["en", "fr"];
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we support more languages but fine for now

Copy link
Copy Markdown
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gitstart-calcom LGTM. great work

@keithwillcode keithwillcode merged commit ac190b8 into main Aug 25, 2023
@keithwillcode keithwillcode deleted the UnpublishedEntity-storybook branch August 25, 2023 12:12
@keithwillcode keithwillcode added the ui area: UI, frontend, button, form, input label Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only Low priority Created by Linear-GitHub Sync ui area: UI, frontend, button, form, input

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

5 participants