Skip to content

chore: add dateRangePicker in storybook (CALCOM-10760)#10836

Closed
gitstart-calcom wants to merge 9 commits intomainfrom
date-range-picker-storybook
Closed

chore: add dateRangePicker in storybook (CALCOM-10760)#10836
gitstart-calcom wants to merge 9 commits intomainfrom
date-range-picker-storybook

Conversation

@gitstart-calcom
Copy link
Copy Markdown
Contributor

@gitstart-calcom gitstart-calcom commented Aug 18, 2023

DEMO

https://www.loom.com/share/4ac79c06acae41c59c53ec7fae73f56e

We don't use className because this property doesn't exist in dateRangePickerComponet, when this component is executed in different files they pass classNames related to the context with tailwind.

props:

image

@vercel
Copy link
Copy Markdown

vercel bot commented Aug 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 5, 2023 0:19am
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 5, 2023 0:19am
cal-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 5, 2023 0:19am
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 5, 2023 0:19am
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 5, 2023 0:19am
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Oct 5, 2023 0:19am
qa ⬜️ Ignored (Inspect) Visit Preview Oct 5, 2023 0:19am

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 18, 2023

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 18, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@alwaysmeticulous
Copy link
Copy Markdown

alwaysmeticulous bot commented Aug 18, 2023

🤖 Meticulous spotted visual differences in 55 of 182 screens tested: view and approve differences detected.

Last updated for commit bfcf5fa. This comment will update as new commits are pushed.

@deploysentinel
Copy link
Copy Markdown

deploysentinel bot commented Aug 18, 2023

Current Playwright Test Results Summary

✅ 143 Passing - ⚠️ 4 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 10/05/2023 12:21:21pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: bfc18b2

Started: 10/05/2023 12:16:33pm UTC

⚠️ Flakes

📄   apps/web/playwright/manage-booking-questions.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Manage Booking Questions For User EventType Split 'Full name' into 'First name' and 'Last name'
Retry 1Initial Attempt
1.22% (3) 3 / 245 runs
failed over last 7 days
1.22% (3) 3 / 245 runs
flaked over last 7 days

📄   apps/web/playwright/login.2fa.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
2FA Tests should allow a user to enable 2FA and login using 2FA
Retry 1Initial Attempt
2.13% (5) 5 / 235 runs
failed over last 7 days
33.62% (79) 79 / 235 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should be able to reschedule
Retry 1Initial Attempt
3.85% (10) 10 / 260 runs
failed over last 7 days
93.08% (242) 242 / 260 runs
flaked over last 7 days

📄   apps/web/playwright/managed-event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Managed Event Types tests Can create managed event type
Retry 1Initial Attempt
3.07% (8) 8 / 261 runs
failed over last 7 days
19.92% (52) 52 / 261 runs
flaked over last 7 days

View Detailed Build Results


@gitstart-calcom gitstart-calcom marked this pull request as ready for review August 18, 2023 12:03
@PeerRich
Copy link
Copy Markdown
Member

this doesnt look like the right date picker

@gitstart-calcom
Copy link
Copy Markdown
Contributor Author

Hi @PeerRich, should we look for another dateRangePicker component or update the classNames to this current tested component? We looked for another dateRangePicker in Calcom and didn't find it
image

@github-actions
Copy link
Copy Markdown
Contributor

This PR is being marked as stale due to inactivity.

@github-actions github-actions bot added the Stale label Sep 26, 2023
@PeerRich
Copy link
Copy Markdown
Member

PeerRich commented Oct 9, 2023

incorrect DatePicker

@PeerRich PeerRich closed this Oct 9, 2023
@keithwillcode keithwillcode deleted the date-range-picker-storybook branch September 17, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only Low priority Created by Linear-GitHub Sync

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

6 participants