chore: add datePicker in storybook (CALCOM-10760)#10784
Conversation
|
Thank you for following the naming conventions! 🙏 |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
Current Playwright Test Results Summary✅ 119 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 08/22/2023 03:19:03am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 80effe1 Started: 08/22/2023 03:16:47am UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
2FA Tests should allow a user to enable 2FA and login using 2FA
Retry 1 • Initial Attempt |
1.27% (3)3 / 236 runsfailed over last 7 days |
19.49% (46)46 / 236 runsflaked over last 7 days |
📄 apps/web/playwright/webhook.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
FORM_SUBMITTED can submit a form and get a submission event
Retry 1 • Initial Attempt |
1.72% (4)4 / 233 runsfailed over last 7 days |
18.88% (44)44 / 233 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
2.98% (7)7 / 235 runsfailed over last 7 days |
97.02% (228)228 / 235 runsflaked over last 7 days |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
sean-brydon
left a comment
There was a problem hiding this comment.
Judging with how this component is styled. I believe this is the wrong date picker.
I did a quick look at refernces and this appears to be dead component that we dont use anywhere
|
Hi @sean-brydon please can you help us to find the correct file? |
|
🤖 Meticulous spotted visual differences in 52 of 124 screens tested: view and approve differences detected. Last updated for commit e4b88a7. This comment will update as new commits are pushed. |
|
definitely wrong component. should we close this PR and open a new one or do you wanna edit this? |
Hi the correct file we use for date picker is located at cal.com/packages/features/calendars/DatePicker.tsx |
We have already updated to the right component in the same PR. We will be pushing the changes shortly |
|
Hi @sean-brydon we made the requested changes here, please take a look |
| <span | ||
| className={classNames( | ||
| "bg-brand-default absolute left-1/2 top-1/2 flex h-[5px] w-[5px] -translate-x-1/2 translate-y-[8px] items-center justify-center rounded-full align-middle sm:translate-y-[12px]", | ||
| active && "invert" |
There was a problem hiding this comment.
We noticed some style issues and fixed them too. Please checkout the video for more detail
https://www.loom.com/share/ed35d62be2d34f199c2af8796b467cce
sean-brydon
left a comment
There was a problem hiding this comment.
Great job :) Thanks for the prompt fixes. Nice spot on the active state too
Demo
https://www.loom.com/share/d610522754bd4e39bca40576a090d0b9