Skip to content

test: Create unit tests for react components in packages/ui/components/top-banner/TopBanner#10705

Merged
shivamklr merged 8 commits intomainfrom
test-top-banner
Aug 25, 2023
Merged

test: Create unit tests for react components in packages/ui/components/top-banner/TopBanner#10705
shivamklr merged 8 commits intomainfrom
test-top-banner

Conversation

@gitstart-calcom
Copy link
Copy Markdown
Contributor

@gitstart-calcom gitstart-calcom commented Aug 10, 2023 •
edited
Loading

What does this PR do?

Create unit tests for TopBanner component

@vercel
Copy link
Copy Markdown

vercel bot commented Aug 10, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 25, 2023 0:34am
cal-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 25, 2023 0:34am
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 25, 2023 0:34am
ui ❌ Failed (Inspect) Aug 25, 2023 0:34am
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Aug 25, 2023 0:34am
qa ⬜️ Ignored (Inspect) Visit Preview Aug 25, 2023 0:34am

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 10, 2023 •
edited
Loading

Thank you for following the naming conventions! 🙏

@zomars zomars added the core area: core, team members only label Aug 10, 2023
gitstart-calcom
gitstart-calcom commented Aug 10, 2023
View reviewed changes
@alwaysmeticulous
Copy link
Copy Markdown

alwaysmeticulous bot commented Aug 10, 2023 •
edited
Loading

🤖 Meticulous spotted visual differences in 19 of 165 screens tested: view and approve differences detected.

Last updated for commit 6c68e22. This comment will update as new commits are pushed.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 10, 2023 •
edited
Loading

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@gitstart-calcom gitstart-calcom mentioned this pull request Aug 10, 2023
Closed
28 tasks
@deploysentinel
Copy link
Copy Markdown

deploysentinel bot commented Aug 10, 2023 •
edited
Loading

Current Playwright Test Results Summary

✅ 122 Passing - ⚠️ 2 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/25/2023 12:37:39pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: cfc495a

Started: 08/25/2023 12:31:28pm UTC

⚠️ Flakes

📄   apps/web/playwright/login.2fa.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
2FA Tests should allow a user to enable 2FA and login using 2FA
Retry 1 • Initial Attempt
1.52% (4) 4 / 264 runs
failed over last 7 days
29.92% (79) 79 / 264 runs
flaked over last 7 days
📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt
0.75% (2) 2 / 268 runs
failed over last 7 days
98.88% (265) 265 / 268 runs
flaked over last 7 days

View Detailed Build Results

@gitstart-calcom gitstart-calcom marked this pull request as ready for review August 10, 2023 16:32
@PeerRich PeerRich added the Low priority Created by Linear-GitHub Sync label Aug 14, 2023
hariombalhara
hariombalhara previously requested changes Aug 24, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@hariombalhara hariombalhara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a reply to work on.

@gitstart-calcom
Copy link
Copy Markdown
Contributor Author

gitstart-calcom commented Aug 24, 2023

Hi @hariombalhara, the requested changes have been made. Please review

shivamklr
shivamklr approved these changes Aug 25, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@shivamklr shivamklr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shivamklr shivamklr enabled auto-merge (squash) August 25, 2023 12:47
@keithwillcode keithwillcode dismissed hariombalhara’s stale review August 25, 2023 12:50

Requested changes made

@shivamklr shivamklr merged commit b1b01ed into main Aug 25, 2023
@shivamklr shivamklr deleted the test-top-banner branch August 25, 2023 12:50
@hariombalhara hariombalhara mentioned this pull request Aug 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@keithwillcode keithwillcode Awaiting requested review from keithwillcode

@sean-brydon sean-brydon Awaiting requested review from sean-brydon

@hariombalhara hariombalhara Awaiting requested review from hariombalhara

1 more reviewer

@shivamklr shivamklr shivamklr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

core area: core, team members only Low priority Created by Linear-GitHub Sync

Projects

No open projects
Reviewing PRs
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@gitstart-calcom @hariombalhara @shivamklr @zomars @PeerRich @gitstart @keithwillcode