test: Create unit tests for react components in packages/ui/components/head-seo/HeadSeo#10699
test: Create unit tests for react components in packages/ui/components/head-seo/HeadSeo#10699hariombalhara merged 4 commits intomainfrom
Conversation
…s/head-seo/HeadSeo
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
|
Thank you for following the naming conventions! 🙏 |
|
🤖 Meticulous spotted visual differences in 93 of 257 screens tested: view and approve differences detected. Last updated for commit f399b7e. This comment will update as new commits are pushed. |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 116 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 08/14/2023 07:03:43pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: f399b7e Started: 08/14/2023 07:01:44pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Stripe integration Paid booking should be able to be rescheduled
Retry 1 • Initial Attempt |
6.25% (20)20 / 320 runsfailed over last 7 days |
8.13% (26)26 / 320 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
3.73% (12)12 / 322 runsfailed over last 7 days |
96.27% (310)310 / 322 runsflaked over last 7 days |
| }); | ||
| }); | ||
|
|
||
| test("Should render without brand", async () => { |
There was a problem hiding this comment.
We need a complementary test as well that verifies that it rendered with brand
There was a problem hiding this comment.
@hariombalhara
Rendering with branding is the default behavior, this is being tested on line 55
There was a problem hiding this comment.
Oh cool !! I think it would make sense to extract that out in a separate test.
There was a problem hiding this comment.
Sure, we will make the required changes and get back to you
hariombalhara
left a comment
There was a problem hiding this comment.
Left 1 comment. Thanks @gitstart-calcom
|
Hi @hariombalhara we made the requested changes please take a look 😄 |
Uh oh!
There was an error while loading. Please reload this page.